From ea893d18a11236a878869166c7cc794862bfd778 Mon Sep 17 00:00:00 2001 From: Roey Berman Date: Mon, 9 Jan 2023 20:00:31 -0800 Subject: [PATCH] Disable eager activities for Python 0.1a1, 0.1a2, and0.1b1 too (#3793) --- service/frontend/overrides.go | 2 +- service/frontend/overrides_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/service/frontend/overrides.go b/service/frontend/overrides.go index c1618cb213a..fadad7f217c 100644 --- a/service/frontend/overrides.go +++ b/service/frontend/overrides.go @@ -45,7 +45,7 @@ func NewOverrides() *Overrides { } func (o *Overrides) shouldForceDisableEagerDispatch(sdkName, sdkVersion string) bool { - if sdkName == headers.ClientNamePythonSDK && sdkVersion == "0.1b2" { + if sdkName == headers.ClientNamePythonSDK && (sdkVersion == "0.1a1" || sdkVersion == "0.1a2" || sdkVersion == "0.1b1" || sdkVersion == "0.1b2") { return true } else if sdkName == headers.ClientNameTypeScriptSDK { ver, err := semver.Parse(sdkVersion) diff --git a/service/frontend/overrides_test.go b/service/frontend/overrides_test.go index 736aa4e5bce..e18f8a8ea21 100644 --- a/service/frontend/overrides_test.go +++ b/service/frontend/overrides_test.go @@ -48,8 +48,8 @@ func TestDisableEagerActivityDispatchForBuggyClients(t *testing.T) { {sdkName: headers.ClientNameGoSDK, sdkVersion: "1.18.1", eagerAllowed: true}, {sdkName: headers.ClientNameTypeScriptSDK, sdkVersion: "1.4.1", eagerAllowed: false}, {sdkName: headers.ClientNameTypeScriptSDK, sdkVersion: "1.4.4", eagerAllowed: true}, + {sdkName: headers.ClientNamePythonSDK, sdkVersion: "0.1a1", eagerAllowed: false}, {sdkName: headers.ClientNamePythonSDK, sdkVersion: "0.1b2", eagerAllowed: false}, - {sdkName: headers.ClientNamePythonSDK, sdkVersion: "0.1b1", eagerAllowed: true}, {sdkName: headers.ClientNamePythonSDK, sdkVersion: "0.1b3", eagerAllowed: true}, } for _, testCase := range cases {