Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 on some images and fonts behind proxy #1885

Open
mtikekar opened this issue Feb 23, 2019 · 11 comments
Open

404 on some images and fonts behind proxy #1885

mtikekar opened this issue Feb 23, 2019 · 11 comments

Comments

@mtikekar
Copy link

I am using tensorboard behind a proxy at www.domain.com/tensorboard and it is making requests to paths such as www.domain.com/font-roboto/... and www.domain.com/tf-interactive-inference-dashboard/...

Can these be changed to have the /tensorboard prefix? FWIW, the --path_prefix option does not add the prefix to these urls.

For bug reports, please include the following:

  • TensorBoard version (from pip package, also printed out when running tensorboard): 1.12.2
  • TensorFlow version if different from TensorBoard: 1.12.0
  • OS Platform and version (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
  • Python version (e.g. 2.7, 3.5): 3.6.7
  • For browser-related issues:
    • Browser type and version (e.g. Chrome 64.0.3282.140)
    • Screenshot if it's a visual issue

Please describe the bug as clearly as possible, and if possible provide a minimal example (code, data, and/or command line) to reproduce the issue. Thanks!

@mtikekar
Copy link
Author

I found the webfiles.zip in the python package installation and copied over font-roboto and tf-interactive-inference-dashboard to the root website so that nginx can serve these static files. But there is also a trace_viewer_index.html and I'm not sure if it is ok for nginx to serve that too.

@nfelt
Copy link
Contributor

nfelt commented Feb 25, 2019

Thanks for the report. The --path_prefix flag was broken in our 1.12 release, the imminent 1.13.0 release contains #1623 which I believe will fix this.

You can try this out by uninstalling tensorboard and installing our nightly build tb-nightly instead.

If for some reason that doesn't fix the issue, comment here and we can reopen and investigate.

@nfelt nfelt closed this as completed Feb 25, 2019
@wchargin
Copy link
Contributor

Can repro on 1.13.0: tensorboard --logdir=x --path_prefix=/foo then
navigate to http://localhost:6006/foo/, and note that the UI is in
sans-serif rather than Roboto (probably doesn’t repro if you have Roboto
or Roboto-Regular as a system font). The JS routing was indeed fixed in
#1623, and the What-If Tool’s images were fixed in #1738, but the fonts
are a separate issue; the CSS always loads from root:

' " src: local(\'Roboto\'), local(\'Roboto-Regular\'), url(/font-roboto/uYECMKoHcO9x1wdmbyHIm3-_kf6ByYO6CLYdB4HQE-Y.woff2) format(\'woff2\');",',

@wchargin wchargin reopened this Feb 25, 2019
@nfelt
Copy link
Contributor

nfelt commented Feb 25, 2019

Hmm, thanks for catching this. Maybe we can just omit the leading / for those urls?

@haobibo
Copy link

haobibo commented Oct 31, 2019

Any progress on this issue? Seem still not resolved in 2.0.1

@adampl
Copy link

adampl commented Jun 17, 2020

The issue with font remains in 2.2.0. Also the profile plugin doesn't respect --path_prefix.

@cliffwoolley
Copy link
Contributor

This impacts jupyter_tensorboard integration as well.

I worked around it for jupyter_tensorboard in cliffwoolley/jupyter_tensorboard@b351bb4 by making a static route for the /font-roboto/ URL prefix to whatever the first TensorBoard instance might be. But I think if we just could patch up the /font-roboto references to be instead ./font-roboto when inlining roboto.html to index.html. I tried ptaching it that way by hand, and the right thing seems to happen.

lspvic/jupyter_tensorboard#63 includes my workaround in the meanwhile.

@XciD
Copy link

XciD commented Dec 15, 2021

Hello, we also have the issue in our tensorboard integration at Huggingface.

@e-carlin
Copy link

+1

@lichunqiang
Copy link

Do you have any updates on this issue?

@mharradon
Copy link

This continues to be an issue. For static assets it appears to be a relatively simple fix to tensorboard/tools/import_google_fonts.py and re-importing so the URLs are relative (missing a leading slash). It may require a bit of string manipulation as-is. Alternately the vendored font files third_party/fonts.bzl can be fixed directly.

The fix would likely be much easier for a Googler - I think it would take some time for an external dev to figure out and setup all the Bazel stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests