Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobsService.updateJob() validation bypass #3716

Open
busma13 opened this issue Aug 9, 2024 · 1 comment
Open

JobsService.updateJob() validation bypass #3716

busma13 opened this issue Aug 9, 2024 · 1 comment

Comments

@busma13
Copy link
Contributor

busma13 commented Aug 9, 2024

I added a check to JobsService.updateJob() that will bypass job validation if the job is going from active to inactive. See: #3471. There were concerns that this could cause the job to end up in an invalid state.

It might be best to add a validation bypass flag to the post _inactive endpoint instead, so the user must actively decide to skip validation. Then setActiveState() could send that bypass argument to updateJob(), ensuring a typical api call to put _update could never skip validation.

@busma13
Copy link
Contributor Author

busma13 commented Oct 7, 2024

If we like the job deletion feature (#3711) then active/inactive will be removed in the near future. At that point we can remove this check entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant