Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop peerDependencies from package.json #610

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

ddolcimascolo
Copy link
Contributor

@ddolcimascolo ddolcimascolo commented Jul 9, 2024

What:

Drop peerDependencies from package.json

Why:

See #608 for the complete motivation, and discussion

Closes #608

How:

Editing package.json

Checklist:

  • Documentation N/A
  • Tests
  • Updated Type Definitions N/A
  • Ready to be merged

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me. I can't merge this though as I'm not an active maintainer.

@gnapse
Copy link
Member

gnapse commented Jul 23, 2024

@ddolcimascolo can you update your upstream main and rebase this on top, or merge the updated main onto your branch? This branch is out-of-date with the base branch, and that's a condition needed for this to be merged.

@ddolcimascolo
Copy link
Contributor Author

@ddolcimascolo can you update your upstream main and rebase this on top, or merge the updated main onto your branch? This branch is out-of-date with the base branch, and that's a condition needed for this to be merged.

Done

@ddolcimascolo
Copy link
Contributor Author

Thx for the 👍, looking forward for a release!

@gnapse gnapse merged commit faf534b into testing-library:main Jul 23, 2024
5 checks passed
@gnapse
Copy link
Member

gnapse commented Jul 23, 2024

@all-contributors please add @ddolcimascolo for maintenance

Copy link
Contributor

@gnapse

I've put up a pull request to add @ddolcimascolo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to have a version not depending on jest, @jest/globals ?
3 participants