Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a way to switch between query and events mode #172

Closed
smeijer opened this issue Jun 16, 2020 · 3 comments · Fixed by #296
Closed

add a way to switch between query and events mode #172

smeijer opened this issue Jun 16, 2020 · 3 comments · Fixed by #296
Labels
feature New feature or request project:events Tickets related to the /events route RFC

Comments

@smeijer
Copy link
Member

smeijer commented Jun 16, 2020

Summary 💡

#167 added an /event route, yet there is no way to come there without knowing the route name. We should add a user accessible way to change mode.

Examples 🌈

Not sure how. Add a route to the nav bar? Add mode buttons to the bottom segment?

Motivation 🔦

Without it, users won't know that it exists.

@smeijer smeijer added feature New feature or request RFC labels Jun 16, 2020
@smeijer smeijer changed the title feat: add a way to switch between query and events mode add a way to switch between query and events mode Jun 16, 2020
@smeijer smeijer added the project:events Tickets related to the /events route label Jun 16, 2020
@aganglada
Copy link
Collaborator

As long as I can see, the events route is the same page but with a different bottom panel. What do you think if we merge them in tabs that way users can switch between them, instead of changing routes (we can lazy load tab contents so we only load that UI if they click on the tab).

So in Playground we could have

|                Preview                 |
------------------------------------------
|     Queries tab.   |     Events tab    |
------------------------------------------
| Queries tab content (opened by default)|

What do you think @smeijer?

@smeijer
Copy link
Member Author

smeijer commented Nov 12, 2020

We should definitely do that. A PR with that change would be much appreciated.

About the tabs, what do you think? Use the same link/tab style as we do in the embed dialog? Those fit nicely in between the panes.

image

@aganglada
Copy link
Collaborator

@smeijer Awesome! will try those and send it over!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request project:events Tickets related to the /events route RFC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants