Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons in the website get misplaced and dropdown does not work in smaller screens. #728

Closed
kishorliv opened this issue Oct 7, 2021 · 6 comments · Fixed by #742
Closed
Assignees
Labels
bug Something isn't working

Comments

@kishorliv
Copy link
Contributor

Describe the issue
In the timetoleave.app website, I found few issues when the screen gets smaller:

  • Intro buttons (Source code and Download) do not align properly.
  • The text inside the buttons do not align centrally.
  • The dropdown menu does not seem to work and is nearly invisible.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'timetoleave.app'
  2. Resize the browser window

Screenshots
timetoleave-site-issue

Is it okay if i fix these issues and open a PR?

@kishorliv kishorliv added the bug Something isn't working label Oct 7, 2021
@thamara
Copy link
Owner

thamara commented Oct 7, 2021

@kishorliv Thanks for reporting and for wanting to work on it!
I have assigned this issue to you :)

@kishorliv
Copy link
Contributor Author

kishorliv commented Oct 10, 2021

Hey @thamara, I ran into an issue while running 'npm ci'. It actually changed package-lock.json without throwing any errors! Upon investigation, I found a similar issue here. My node version is 14.15.6 and npm version is 7.24.2.

The change in the file itself is nothing but coming from .editorconfig, an extra whitespace in the end and indent size of 4. I am not sure if this is specific to my workspace settings because .editorconfig file overrides user's workspace settings.

I think I might be missing something since no one seems to have encountered this issue. Please let me know if there's a way to solve this. Thanks.

@tupaschoal
Copy link
Collaborator

@kishorliv though the issue seems somewhat concerning, I couldn't understand whether it prevented you from running the app or the website and going after the issue, can you add more details, please?

@kishorliv
Copy link
Contributor Author

@tupaschoal no the app runs fine. I started working on the issue yesterday so will probably send a PR by today.

@tupaschoal
Copy link
Collaborator

Nice!

@thamara
Copy link
Owner

thamara commented Oct 13, 2021

I started reading why package-lock.json might get to be different, and it's related to how we specify our dependencies (using ^ for example). But I didn't went further, as this doesn't seem like a big issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants