Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruler: prometheus_rule_group_last_duration_seconds is not working. #1027

Closed
bwplotka opened this issue Apr 11, 2019 · 7 comments
Closed

ruler: prometheus_rule_group_last_duration_seconds is not working. #1027

bwplotka opened this issue Apr 11, 2019 · 7 comments

Comments

@bwplotka
Copy link
Member

I can see the values out of the world totally. Is it even updated? Let's fix this.

@yeya24
Copy link
Contributor

yeya24 commented Apr 12, 2019

In prometheus 2.7.1, this metric used seconds instead of nanoseconds.
Here is the PR #5153.
And in thanos, it is still the old package using nanoseconds.

func (g *Group) setEvaluationDuration(dur time.Duration) {
	g.metrics.groupLastDuration.WithLabelValues(groupKey(g.file, g.name)).Set(float64(dur))

	g.mtx.Lock()
	defer g.mtx.Unlock()
	g.evaluationDuration = dur
}

@bwplotka
Copy link
Member Author

Wow, thanks for this, that might be it. But still it's bit off

@GiedriusS
Copy link
Member

Was this fixed after the library has been updated? 😄

@yeya24
Copy link
Contributor

yeya24 commented Jul 17, 2019

Is this issue fixed now?

@jojohappy
Copy link
Member

@yeya24 It seems to be fixed in #1009 with v0.4.0. Let's double check it.

@simonpasquier
Copy link
Contributor

Using master, I see that prometheus_rule_group_last_duration_seconds values match with the rules UI.

@stale
Copy link

stale bot commented Jan 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 11, 2020
@stale stale bot closed this as completed Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants