Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecar: Do no upload blocks until first UpdateLabels (for exernal labels) #1239

Closed
bwplotka opened this issue Jun 10, 2019 · 1 comment
Closed

Comments

@bwplotka
Copy link
Member

Right now if we cannot talk to Prometheus due to configuration error (e.g wrong value in prometheus.url) flag, we cannot fetch external labels.

This means that if upload is enabled we upload blocks without any external labels even though we had info early that we retry.

This is combined with wrong readiness probe marking on Kubernetes.

AC:

  • Start uploading ONLY after we have external labels known.
  • Crash after X retries?
@GiedriusS
Copy link
Member

GiedriusS commented Jul 22, 2019

I believe this has been fixed in #1287 - now we wait until the external label info is known before starting the uploading process. Thus I'm closing it 😄 @bwplotka please reopen this if this hasn't been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants