Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command-line flags page for query instances is not populated #248

Closed
mattbostock opened this issue Mar 19, 2018 · 3 comments · Fixed by #1216
Closed

Command-line flags page for query instances is not populated #248

mattbostock opened this issue Mar 19, 2018 · 3 comments · Fixed by #1216

Comments

@mattbostock
Copy link
Contributor

mattbostock commented Mar 19, 2018

The 'command-line flags' page is visible in the UI for query instances, but is not populated.

If the UI is only enabled on the query instances, perhaps it's not worth including this in the UI and would be better as an API endpoint?

It's inconsistent to expose this information for query instances but not other instance types, so maybe we should remove it entirely.

@bwplotka
Copy link
Member

Other instance types like store, sidecar etc? Well, they don't have UI so there is no inconsistency. But let's remove it if it's not even populated - fair point.

@mattbostock
Copy link
Contributor Author

mattbostock commented Mar 25, 2018

Well, they don't have UI so there is no inconsistency.

That's part of where the inconsistency stems from, i.e. why would someone use the UI to know the command-line flags for the query instance but not expect the same for the other instances.

I think it'd be better to remove the command-line flags from the UI for now. If they're deemed useful, they could in future be exposed on an API endpoint instead.

@bwplotka
Copy link
Member

Totally agree 👍

However, I am looking forward to seeing some other useful UI views like:

  • store/query nodes in the system and their labels/time ranges at the time.
  • last storeAPI errors if any
    There was an idea to add these in a totally new UI, but maybe worth to add these in current UI ASAP as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants