Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support context propagation in the Swift storage integration #3556

Closed
FUSAKLA opened this issue Dec 9, 2020 · 5 comments
Closed

Support context propagation in the Swift storage integration #3556

FUSAKLA opened this issue Dec 9, 2020 · 5 comments

Comments

@FUSAKLA
Copy link
Member

FUSAKLA commented Dec 9, 2020

Is your proposal related to a problem?

The Swift storage integration is based on a library that does not support context propagation and allows just setting static timeouts currently. There is a standing issue on it to support the context. Once added there, Thanos should start using it also.

Issue on the used library ncw/swift#159
Related discussion in Thanos PR #2732 (comment)

@FUSAKLA FUSAKLA self-assigned this Dec 9, 2020
@GiedriusS GiedriusS changed the title Support context propadation in the Swift storage integration Support context propagation in the Swift storage integration Dec 9, 2020
@FUSAKLA
Copy link
Member Author

FUSAKLA commented Dec 19, 2020

Created a PR to add context support to the library we use ncw/swift#162

@stale
Copy link

stale bot commented Feb 18, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Feb 18, 2021
@FUSAKLA
Copy link
Member Author

FUSAKLA commented Feb 18, 2021

Still valid, I managed to add the support to the library ended up with a new major release.
I'll send a PR for upgrade here

@stale stale bot removed the stale label Feb 18, 2021
@stale
Copy link

stale bot commented Jun 3, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 3, 2021
@stale
Copy link

stale bot commented Jun 18, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant