Thanos Tools Downsample Shutting Down without Reason

[nicolastakashi]

Thanos, Prometheus and Golang version used:

Thanos 0.24

Object Storage Provider:

Azure Blob Storage

What happened:

When I'm running the Thanos tools downsample command, I'm the command is finished by an internal server error without providing context.

What you expected to happen:

Be able to downsample data as a service.

How to reproduce it (as minimally and precisely as possible):

I just try to run the command as described above against the storage.

./thanos tools bucket downsample --objstore.config-file=storage.yaml --downsample.concurrency=1 --log.level=info

Full logs to relevant components:

level=info ts=2022-01-18T11:31:47.690110153Z caller=downsample.go:164 msg="starting downsample node"
level=info ts=2022-01-18T11:31:47.690263439Z caller=intrumentation.go:48 msg="changing probe status" status=ready
level=info ts=2022-01-18T11:31:47.690362235Z caller=downsample.go:117 msg="start first pass of downsampling"
level=info ts=2022-01-18T11:31:47.690449192Z caller=intrumentation.go:60 msg="changing probe status" status=healthy
level=info ts=2022-01-18T11:31:47.690525045Z caller=http.go:63 service=http/server component=downsample msg="listening for requests and metrics" address=0.0.0.0:10902
level=info ts=2022-01-18T11:31:47.690888877Z caller=tls_config.go:195 service=http/server component=downsample msg="TLS is disabled." http2=false
level=info ts=2022-01-18T11:31:52.118450487Z caller=fetcher.go:481 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=4.428046733s duration_ms=4428 cached=526 returned=526 partial=0
level=info ts=2022-01-18T11:31:52.124909498Z caller=downsample.go:132 msg="start second pass of downsampling"
level=info ts=2022-01-18T11:31:53.288659373Z caller=fetcher.go:481 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=1.163633704s duration_ms=1163 cached=526 returned=526 partial=0
level=warn ts=2022-01-18T11:31:53.290916369Z caller=intrumentation.go:54 msg="changing probe status" status=not-ready reason=null
level=info ts=2022-01-18T11:31:53.290971518Z caller=http.go:74 service=http/server component=downsample msg="internal server is shutting down" err=null
level=info ts=2022-01-18T11:31:53.292400844Z caller=http.go:93 service=http/server component=downsample msg="internal server is shutdown gracefully" err=null
level=info ts=2022-01-18T11:31:53.292477557Z caller=intrumentation.go:66 msg="changing probe status" status=not-healthy reason=null
level=info ts=2022-01-18T11:31:53.292593896Z caller=main.go:161 msg=exiting

Anything else we need to know:

[yeya24]

Yeah, looks like this command is for one pass run.
Continuously downsamples blocks in an object store bucket. That's the command description so I think we should fix it and make it long running.