Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Enable allow overlapping blocks by default #5790

Open
yeya24 opened this issue Oct 13, 2022 · 0 comments
Open

*: Enable allow overlapping blocks by default #5790

yeya24 opened this issue Oct 13, 2022 · 0 comments

Comments

@yeya24
Copy link
Contributor

yeya24 commented Oct 13, 2022

Is your proposal related to a problem?

After Prometheus dependency got upgraded to #5771, allow overlapping blocks is enabled by default for TSDBs. We have other components that are related to overlapping blocks checking.

  1. Compactor. Compaction has a flag compact.enable-vertical-compaction to check whether to enable vertical compaction or not. We should make this enable by default, too.
  2. Shipper. This one is more interesting. Now shipper disallows out of order block uploading and needs a flag shipper.allow-out-of-order-uploads to enable this. With vertical compaction enabled out of order upload shouldn't be an issue. But I'd love to hear more ideas whether we want to enable this or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant