From 55d8068071f3061428dc3b2ff1e4a476b7f5caea Mon Sep 17 00:00:00 2001 From: aribalam Date: Wed, 16 Sep 2020 23:23:42 +0530 Subject: [PATCH 1/4] added info level logging for code [300-400) Signed-off-by: aribalam --- pkg/logging/options.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/logging/options.go b/pkg/logging/options.go index 0e4bb89847..a991353eea 100644 --- a/pkg/logging/options.go +++ b/pkg/logging/options.go @@ -98,6 +98,9 @@ func DefaultCodeToLevel(logger log.Logger, code int) log.Logger { if code >= 200 && code < 300 { return level.Debug(logger) } + if code >= 300 && code < 400 { + return level.Info(logger) + } if code >= 400 && code < 500 { return level.Debug(logger) } From 1ff4cb0f16ce3822aba776c9554381329abb3bcf Mon Sep 17 00:00:00 2001 From: aribalam Date: Thu, 17 Sep 2020 09:30:18 +0530 Subject: [PATCH 2/4] changed to debug level for responses between [200, 500) Signed-off-by: aribalam --- pkg/logging/options.go | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/pkg/logging/options.go b/pkg/logging/options.go index a991353eea..a119c08ae2 100644 --- a/pkg/logging/options.go +++ b/pkg/logging/options.go @@ -95,13 +95,7 @@ type options struct { // DefaultCodeToLevel is the helper mapper that maps HTTP Response codes to log levels. func DefaultCodeToLevel(logger log.Logger, code int) log.Logger { - if code >= 200 && code < 300 { - return level.Debug(logger) - } - if code >= 300 && code < 400 { - return level.Info(logger) - } - if code >= 400 && code < 500 { + if code >= 200 && code < 500 { return level.Debug(logger) } return level.Error(logger) From 7e50231ba56178e46cf76024a959460437f20c1c Mon Sep 17 00:00:00 2001 From: aribalam Date: Thu, 17 Sep 2020 09:34:56 +0530 Subject: [PATCH 3/4] updated changelog Signed-off-by: aribalam --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a356c8dae1..7665dafe88 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re ### Added +- [#3181](https://github.com/thanos-io/thanos/pull/3181) Query Frontend: Add debug level logging for responses between 300-399 - [#3133](https://github.com/thanos-io/thanos/pull/3133) Query: Allow passing a `storeMatch[]` to Labels APIs. Also time range metadata based store filtering is supported on Labels APIs. - [#3154](https://github.com/thanos-io/thanos/pull/3154) Query Frontend: Add metric `thanos_memcached_getmulti_gate_queries_max`. - [#3146](https://github.com/thanos-io/thanos/pull/3146) Sidecar: Add `thanos_sidecar_prometheus_store_received_frames` histogram metric. From 5230cb1aa4543124cd5f046f2ee0a317677ba1a8 Mon Sep 17 00:00:00 2001 From: aribalam Date: Thu, 17 Sep 2020 22:09:44 +0530 Subject: [PATCH 4/4] changed changelog title Signed-off-by: aribalam --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7665dafe88..dcfbe44b48 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,7 +13,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re ### Added -- [#3181](https://github.com/thanos-io/thanos/pull/3181) Query Frontend: Add debug level logging for responses between 300-399 +- [#3181](https://github.com/thanos-io/thanos/pull/3181) Logging: Add debug level logging for responses between 300-399 - [#3133](https://github.com/thanos-io/thanos/pull/3133) Query: Allow passing a `storeMatch[]` to Labels APIs. Also time range metadata based store filtering is supported on Labels APIs. - [#3154](https://github.com/thanos-io/thanos/pull/3154) Query Frontend: Add metric `thanos_memcached_getmulti_gate_queries_max`. - [#3146](https://github.com/thanos-io/thanos/pull/3146) Sidecar: Add `thanos_sidecar_prometheus_store_received_frames` histogram metric.