Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ls-files so it now works with Git 2.16 and later #5851

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

westbury
Copy link
Contributor

@westbury westbury commented Aug 4, 2019

This fixes a problem that occurs when a Git repository is empty (the initial commit has not yet been made) and Git version 2.16 or later is being used.

With Git version 2.16, the ls-files command now requires '.' be specified to indicate all files. It is no longer acceptable to omit the arg. Without the fix, one got this:
image

With the fix one gets:
image

This will also fix the lsFiles for other users of the function.

Signed-off-by: Nigel Westbury <nigelipse@miegel.org>
@akosyakov akosyakov added the git issues related to git label Aug 5, 2019
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified it locally; it works as expected. 👍

Thank you for the help, @westbury!

@kittaakos kittaakos merged commit bd6aae7 into eclipse-theia:master Aug 6, 2019
@westbury westbury deleted the lsfiles-fix branch August 6, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git issues related to git
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants