From 56eddfeb1099a95098e8b182833e762d0b40bf4e Mon Sep 17 00:00:00 2001 From: Andy Ross Date: Thu, 31 Aug 2023 12:48:34 -0700 Subject: [PATCH 1/3] mt8195: Bump task stack size for Google AEC AEC initialization is stack-hungry, needing ~6kb during initialization. That happens under the IPC task, not a component-local stack. So bump the default for all tasks as that's the only way to make sure IPC gets it. (Really this shouldn't be a platform choice, but that's where the symbol exists) Signed-off-by: Andy Ross --- src/platform/mt8195/include/platform/lib/memory.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/platform/mt8195/include/platform/lib/memory.h b/src/platform/mt8195/include/platform/lib/memory.h index 47bb91202bfb..78d21faac476 100644 --- a/src/platform/mt8195/include/platform/lib/memory.h +++ b/src/platform/mt8195/include/platform/lib/memory.h @@ -165,7 +165,11 @@ #define HEAP_BUF_ALIGNMENT DCACHE_LINE_SIZE /** \brief EDF task's default stack size in bytes. */ +#ifdef CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING +#define PLATFORM_TASK_DEFAULT_STACK_SIZE 8192 +#else #define PLATFORM_TASK_DEFAULT_STACK_SIZE 3072 +#endif #if !defined(__ASSEMBLER__) && !defined(LINKER) From cac0fdc2eaf5f705c7d0182b0665f44daa64dc82 Mon Sep 17 00:00:00 2001 From: Andy Ross Date: Wed, 15 Nov 2023 11:39:51 -0800 Subject: [PATCH 2/3] topology1/mt8195: Add Graphviz output markers Add the .dot file header/footer macros. These are benign if unused, and it seems like most other devices have them defined. Signed-off-by: Andy Ross --- tools/topology/topology1/sof-mt8195-mt6359-rt1019-rt5682.m4 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/topology/topology1/sof-mt8195-mt6359-rt1019-rt5682.m4 b/tools/topology/topology1/sof-mt8195-mt6359-rt1019-rt5682.m4 index cfe0a9c3e800..a171e83c3988 100644 --- a/tools/topology/topology1/sof-mt8195-mt6359-rt1019-rt5682.m4 +++ b/tools/topology/topology1/sof-mt8195-mt6359-rt1019-rt5682.m4 @@ -20,6 +20,8 @@ include(`sof/tokens.m4') # Include DSP configuration include(`platform/mediatek/mt8195.m4') +DEBUG_START + # # Define the demux configure # @@ -187,3 +189,5 @@ DAI_CONFIG(AFE, 2, 0, AFE_SOF_UL4, DAI_CONFIG(AFE, 3, 0, AFE_SOF_UL5, AFE_CONFIG(AFE_CONFIG_DATA(AFE, 3, 48000, 2, s16le))) + +DEBUG_END From 291dcb75e897079893a69712d4621638bb256d69 Mon Sep 17 00:00:00 2001 From: Andy Ross Date: Sat, 9 Dec 2023 07:57:56 -0800 Subject: [PATCH 3/3] mt8195: Disable GOOGLE AEC MOCK by default The mocking layer is an important debugging tool. It shouldn't be on by default lest we accidentally build without the real feature. Signed-off-by: Andy Ross --- .../xtensa/configs/override/mt8195_chrome_google_rtc_rtnr.config | 1 - 1 file changed, 1 deletion(-) diff --git a/src/arch/xtensa/configs/override/mt8195_chrome_google_rtc_rtnr.config b/src/arch/xtensa/configs/override/mt8195_chrome_google_rtc_rtnr.config index 76fd2cc54ad1..7a0c166abb57 100644 --- a/src/arch/xtensa/configs/override/mt8195_chrome_google_rtc_rtnr.config +++ b/src/arch/xtensa/configs/override/mt8195_chrome_google_rtc_rtnr.config @@ -1,4 +1,3 @@ CONFIG_COMP_RTNR=y CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING=y -CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK=y CONFIG_COMP_MUX=y