Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for online-sign and build-repository #343

Open
jku opened this issue May 22, 2024 · 1 comment
Open

Validation for online-sign and build-repository #343

jku opened this issue May 22, 2024 · 1 comment

Comments

@jku
Copy link
Member

jku commented May 22, 2024

I would like online sign and build-repository to do more data validation:

  • online-sign should check that targets metadata is valid and artifacts are found
    (note that delegated targets may be allowed to be expired)
  • build-repository should check that all metadata and artifacts are valid
    • this should include checking that root versions in root_history/ are valid -- although care needs to be taken since potentially some imported root metadata is not valid according to tuf-on-ci (see e.g. sigstore root-signing)
  • as an additional check could test that the keyids are compliant (since python-tuf does not do that, see Fix noncompliant keyids #338)

There is a CIRepository._validate_role() but that is very focused on the signing event use case: in particular it expects there to be a "previous repository version" (self.open_prev() opens that version of a specific metadata) which only makes sense in a signing event.

Possibly we can make a more generic validate_role() and a more specific validate_signing_event_role() that uses the generic method but does the comparison to previous version as well.

@jku
Copy link
Member Author

jku commented May 27, 2024

  • check that root.json matches root_history/{version}.root.json, and that it is the highest version in root_history/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant