Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11 colors support #25

Open
steffex opened this issue Apr 29, 2014 · 9 comments
Open

x11 colors support #25

steffex opened this issue Apr 29, 2014 · 9 comments
Labels

Comments

@steffex
Copy link

steffex commented Apr 29, 2014

Currently I'm short on time, but I'll add my X11 colors (https://github.com/steffex/x11Colors) library to this one!

@dblock dblock added the feature label Apr 29, 2014
@dblock
Copy link
Collaborator

dblock commented Apr 29, 2014

👍

@dblock
Copy link
Collaborator

dblock commented Apr 29, 2014

It will need some consistent naming with EDColor's standards, like iOS7greenColor, and tests and demo, otherwise looks great.

@steffex
Copy link
Author

steffex commented Apr 29, 2014

will do! 😄

@thisandagain
Copy link
Owner

Sounds great!

@steffex
Copy link
Author

steffex commented Jun 2, 2014

@dblock / @thisandagain would this naming convention work for you guys: x11PeachPuff

@dblock
Copy link
Collaborator

dblock commented Jun 2, 2014

I think so. I wonder whether it should be x11peachPuff, but I don't have strong preferences.

@steffex
Copy link
Author

steffex commented Jun 2, 2014

If we want to be consistent, we should do x11peachPuff IMO.

Hopefully I'll be able to get something done after work.

@steffex
Copy link
Author

steffex commented Jun 2, 2014

@dblock also how should the naming of the class method be?

in my class it's now x11ColorWithName, but perhaps colorWithX11Name or colorWithx11Name is better?!

@dblock
Copy link
Collaborator

dblock commented Jun 2, 2014

Maybe you can look at all the other classes? I am happy with standardizing either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants