Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistency in fromarray #289

Closed
jwittenbach opened this issue Apr 26, 2016 · 1 comment
Closed

inconsistency in fromarray #289

jwittenbach opened this issue Apr 26, 2016 · 1 comment
Labels
beginner friendly bug in progress

Comments

@jwittenbach
Copy link
Contributor

When Series.fromarray is passed a BoltArraySpark object with no explicit engine, the resulting Series object has the same mode ("spark" vs "local") as the argument.

However, when the same function is passed a Series object, the resulting Series always defaults to have the mode set to "local".
jwittenbach added a commit to jwittenbach/thunder that referenced this issue Apr 26, 2016
@jwittenbach
closes thunder-project#289 by extending Images and Series fromarray m…
6c83337 
…ethods to handle Thunder objects
@jwittenbach jwittenbach mentioned this issue Apr 26, 2016
Closed
@jwittenbach
Copy link
Contributor Author

After looking at the code for Series.fromarray and Images.fromarray it looks like these methods were never meant to handle Thunder objects, but the just happened to not fail when applied to them. The submitted PR extends the functionality of these methods to handle being passed Images and Series objects appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly bug in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extending fromarray methods jwittenbach/thunder
1 participant
@jwittenbach