diff --git a/types/json/binary_functions.go b/types/json/binary_functions.go index d7c9763d09c4c..69f9788acf19e 100644 --- a/types/json/binary_functions.go +++ b/types/json/binary_functions.go @@ -221,6 +221,10 @@ func (bj BinaryJSON) Extract(pathExprList []PathExpression) (ret BinaryJSON, fou // even if len(pathExprList) equals to 1. found = true ret = buf[0] + // Fix https://github.com/pingcap/tidb/issues/30352 + if pathExprList[0].ContainsAnyAsterisk() { + ret = buildBinaryArray(buf) + } } else { found = true ret = buildBinaryArray(buf) diff --git a/types/json/binary_test.go b/types/json/binary_test.go index 2d7fe58ee4eb8..1e2903d3066fa 100644 --- a/types/json/binary_test.go +++ b/types/json/binary_test.go @@ -62,7 +62,16 @@ func TestBinaryJSONExtract(t *testing.T) { {bj1, []string{"$.*[0]"}, mustParseBinaryFromString(t, `["world", 1, true, "d"]`), true, nil}, {bj1, []string{`$.a[*]."aa"`}, mustParseBinaryFromString(t, `["bb", "cc"]`), true, nil}, {bj1, []string{`$."\"hello\""`}, mustParseBinaryFromString(t, `"world"`), true, nil}, +<<<<<<< HEAD {bj1, []string{`$**[1]`}, mustParseBinaryFromString(t, `"2"`), true, nil}, +======= + {bj1, []string{`$**[1]`}, mustParseBinaryFromString(t, `["2"]`), true, nil}, + {bj3, []string{`$.properties.$type`}, mustParseBinaryFromString(t, `"TiDB"`), true, nil}, + {bj4, []string{`$.properties.$type$type`}, mustParseBinaryFromString(t, `{"$a$a" : "TiDB"}`), true, nil}, + {bj4, []string{`$.properties.$type$type.$a$a`}, mustParseBinaryFromString(t, `"TiDB"`), true, nil}, + {bj5, []string{`$.properties.$type.$a.$b`}, mustParseBinaryFromString(t, `"TiDB"`), true, nil}, + {bj5, []string{`$.properties.$type.$a.*[0]`}, mustParseBinaryFromString(t, `["TiDB"]`), true, nil}, +>>>>>>> ed5e63a7a... types: fix incompatible implementation of jsonpath extraction (#35320) // test extract with multi path expressions. {bj1, []string{"$.a", "$[5]"}, mustParseBinaryFromString(t, `[[1, "2", {"aa": "bb"}, 4.0, {"aa": "cc"}]]`), true, nil},