Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed columns in glance.aov() #864

Closed
simonpcouch opened this issue May 27, 2020 · 1 comment
Closed

Removed columns in glance.aov() #864

simonpcouch opened this issue May 27, 2020 · 1 comment

Comments

@simonpcouch
Copy link
Collaborator

One more reverse dependency failure for 0.7.0 that's yet to be addressed. Seems like there’s been quite a bit of discussion about the aov tidiers. The r.squared and adj.r.squared columns were recently removed from glance.aov(), but don't seem to be an issue in the existing discussions on the method (#273, #626, #862). Considering adding those columns back in to the output.

Waiting on filing issues/PRs for now.

CGPfunctions

Run revdep_details(,"CGPfunctions") for more info

Newly broken

  • checking examples ... ERROR
    ...
    > ### ** Examples
    > 
    > 
    > Plot2WayANOVA(mpg ~ am * cyl, mtcars, plottype = "line")
    
    Converting am to a factor --- check your results
    
    Converting cyl to a factor --- check your results
    Warning: Unknown or uninitialised column: `r.squared`.
    Warning: Unknown or uninitialised column: `r.squared`.
    Warning: Unknown or uninitialised column: `r.squared`.
    Warning: Unknown or uninitialised column: `r.squared`.
    Warning in max(limit1, limit2) :
      no non-missing arguments to max; returning -Inf
    Warning in min(limit1, limit2) :
      no non-missing arguments to min; returning Inf
    Warning: Unknown or uninitialised column: `r.squared`.
    Error in round(model_summary$r.squared, 3) : 
      non-numeric argument to mathematical function
    Calls: Plot2WayANOVA
    Execution halted
    
@github-actions
Copy link

github-actions bot commented Mar 8, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant