Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse dependency checks for 0.7.0, round 3 #885

Closed
simonpcouch opened this issue Jun 24, 2020 · 3 comments
Closed

reverse dependency checks for 0.7.0, round 3 #885

simonpcouch opened this issue Jun 24, 2020 · 3 comments

Comments

@simonpcouch
Copy link
Collaborator

simonpcouch commented Jun 24, 2020

Another round of reverse dependency checks for broom 0.7.0 (on the 0.7.0-rc branch)—since the first round of checks in #862, 20 of 37 contacted maintainers have updated their packages on CRAN, and we've also softened some deprecations since round 2 of revdepchecks, at the CRAN team's request, resulting in 3 prior failures being remedied. I'll keep this table up to date as I check in on each of these issues.

New problems (20)

package version ERROR WARNING NOTE additional notes
allestimates 0.1.6 +1 1 (Same issue as before—changes to conf.int defaults.) Not hosted on GitHub, so reached out to the maintainer by email again.
arsenal 3.4.0 +1 Same issue as before—fixed on the devel masterbranch a month ago—waiting to submit until 0.7.0 is posted.
CGPfunctions 0.6.1 +1 Same issue as before—changes to supplied columns in tidy.aov.) Dropped a note in the issue from the first round of checks.
chest 0.3.1 +1 1 Same issue as before. Fixed on the devel branch master, and will be submitted once broom is on CRAN.
ERSA 0.1.1 +1 Same issue as before—no response on the initial GitHub issue, just dropped another note.
eyetrackingR 0.1.8 +2 Same issue as before. Still no longer maintained.
forestmodel 0.5.0 +1 Same issue as before. Checked in on the issue from the first round of checks.
ggasym 0.1.4 +1 Same issue as before—Results from warning -> error switch (unit tests reflected broom functionality). Fixed 25 days ago on the devel branch, will be submitted to CRAN once broom is released.
glmmfields 0.1.3 1 +1 Same issue as before—results from planned deprecation of mixed model tidiers to broom.mixed. Fixed 28 days ago on the devel branch and will be submitted to CRAN once broom is released.
konfound 0.2.1 +2 1 Same issue as before—results from planned deprecation of mixed model tidiers to broom.mixed. No response on the issue filed a month ago, just checked in again.
mice 3.9.0 +1 Same issue as before—relevant to changes in glance.*() methods for lm and aov objects. Fixed 25 days ago and on its way to CRAN.
moderndive 0.4.0 +1 1 Same issue as before, fixed on master branch.
nlstimedist 1.1.4 +1 Same issue as before, fixed on master branch.
radiant.model 1.3.10 +1 Same issue as before—maintainer has noted that they will submit the necessary changes as soon as the new version of broom hits CRAN—the relevant breakages are due to the change in how degrees of freedom are supported, so a workaround for supporting both versions would be messy.
RCT 1.0.2 +2 Same issue as before. Checking in on the initial issue.
survminer 0.4.7 +1 1 Unrelated to broom and addressed on issue 472 of the package.
survutils 1.0.2 +1 Same issue as before—related to changes in conf.int defaults. Checked in on the issue filed a month ago.

Update 24 June 2020—just worked through each of these issues. Of the 17 remaining issues, 9 of them have been fixed in development versions and are waiting on the release of 0.7.0 to submit. I've reached out to maintainers for all remaining issues, besides eyetrackingR which currently does not have a maintainer.

@simonpcouch simonpcouch mentioned this issue Jun 24, 2020
19 tasks
@vnijs
Copy link

vnijs commented Jun 24, 2020

FYI I will update radiant.model as soon as the new version of broom hits and make 0.7.0 required. With the changes in how dfs are reported by broom for logistic regression it would be a bit of a mess to support multiple versions.

@simonpcouch
Copy link
Collaborator Author

@vnijs Sounds great, thanks! Will make note of that. :-)

@github-actions
Copy link

github-actions bot commented Mar 7, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants