Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN Check Failure for Upcoming broom Release #15

Open
simonpcouch opened this issue May 27, 2020 · 0 comments
Open

CRAN Check Failure for Upcoming broom Release #15

simonpcouch opened this issue May 27, 2020 · 0 comments

Comments

@simonpcouch
Copy link

Hi there! The broom dev team just ran reverse dependency checks on the upcoming broom 0.7.0 release and found new errors/test failures for the CRAN version of this package. I've pasted the results below.

  • checking tests ...
     ERROR
    Running the tests in ‘tests/testthat.R’ failed.
    Last 13 lines of output:
      > 
      > test_check("survutils")
      [31m──[39m [31m1. Failure: get_cox_res runs univariate Cox regression on a single feature (@[39m
      as.data.frame(out_df) not equal to as.data.frame(expected_out_df).
      Names: 1 string mismatch
      Length mismatch: comparison on first 6 components
      Component 6: Modes: character, numeric
      Component 6: target is character, current is numeric
      
      ══ testthat results  ═══════════════════════════════════════════════════════════
      [ OK: 6 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 1 ]
      1. Failure: get_cox_res runs univariate Cox regression on a single feature (@test_get_cox_res.R#48) 
      
      Error: testthat unit tests failed
      Execution halted
    

I believe this test failure is caused by the following change:

All conf.int arguments now default to FALSE, and all conf.level arguments now default to 0.95.

We made this change as confidence interval calculations for many model objects are computationally intensive.

If so, just set conf.int = TRUE in your calls to tidy.*() methods and you should be good to go!🙂

We hope to submit this new version of the package to CRAN in the coming weeks. If you encounter any problems fixing these issues, please feel free to reach out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant