Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change floats to doubles #5

Open
tokenrove opened this issue Jun 16, 2016 · 0 comments
Open

Change floats to doubles #5

tokenrove opened this issue Jun 16, 2016 · 0 comments

Comments

@tokenrove
Copy link
Owner

Most of the uses of float in this code should be double from the point of view of accuracy, and should have negligible speed impact.
tokenrove added a commit that referenced this issue Jun 25, 2016
@tokenrove
Change type of sky ratio so it is actually a ratio
61c9234 
Although all these values should probably be floats (#5), the checks
of this value against sky_threshold certainly weren't working as
designed with it being an int.

Fixes #4.
tokenrove added a commit that referenced this issue Jul 3, 2016
@tokenrove
Change type of sky ratio so it is actually a ratio
ad05389 
Although all these values should probably be floats (#5), the checks
of this value against sky_threshold certainly weren't working as
designed with it being an int.

Fixes #4.
tokenrove added a commit that referenced this issue Jul 17, 2016
@tokenrove
Change type of sky ratio so it is actually a ratio
2239091 
Although all these values should probably be floats (#5), the checks
of this value against sky_threshold certainly weren't working as
designed with it being an int.

Fixes #4.
tokenrove added a commit that referenced this issue Jul 17, 2016
@tokenrove
Change type of sky ratio so it is actually a ratio
e619152 
Although all these values should probably be floats (#5), the checks
of this value against sky_threshold certainly weren't working as
designed with it being an int.

Fixes #4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tokenrove