Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release initial version #66

Closed
xd009642 opened this issue Oct 5, 2021 · 6 comments
Closed

Release initial version #66

xd009642 opened this issue Oct 5, 2021 · 6 comments

Comments

@xd009642
Copy link

xd009642 commented Oct 5, 2021

So valuable integration has started in tracing ( tokio-rs/tracing#1608 ) but a blocker for merging it is that valuable needs a release on crates.io. I'm aware there's a milestone for features for the 0.1 release so if that's not ready potentially an alpha release? Or depending on the milestone features punt them to a patch or the next version

@carllerche
Copy link
Member

@taiki-e are you able to help w/ getting 0.1 ready to be released?

@carllerche
Copy link
Member

Looks like @hawkw owns the crate name. I requested permission.

@hawkw
Copy link
Member

hawkw commented Oct 5, 2021

Looks like @hawkw owns the crate name. I requested permission.

@tokio-rs/core should have publish rights now!

@taiki-e taiki-e added this to the v0.1 - Initial release milestone Oct 7, 2021
@KodrAus
Copy link

KodrAus commented Oct 8, 2021

For what it's worth, I've spent a bit of time poking at valuable recently from an integration perspective with other serialization approaches and haven't run into anything that really blocked me.

Besides #58 (which is already in the milestone, and I imagine would be desirable for tracing anyways since they already use a 'static bound IIRC), a resolution for #65 one way or another might also be nice because even though it could be added as a non-breaking change, it would be a change in the contract that could affect downstream consumers.

@xd009642
Copy link
Author

@taiki-e @carllerche how many of the milestone issues must go in before the initial release? Or are there some that the team would be comfortable punting to the next release? Just out of curiosity as I'd like to help clear any of the blockers if possible

@taiki-e taiki-e removed their assignment Jan 4, 2022
@taiki-e
Copy link
Member

taiki-e commented Jan 4, 2022

https://crates.io/crates/valuable/0.1.0

@taiki-e taiki-e closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants