Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Runtime' node port 'in' metrics are missing in tremor-0.7.4-alpha verison #211

Closed
rajasimha1991 opened this issue Apr 30, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@rajasimha1991
Copy link
Contributor

Problem
We recently upgraded tremor from 0.6.1 to 0.7.4alpha version. After upgrading we are not able to collect metrics for runtime node in port. We were able to collect metrics in the earlier version.

Steps

  1. Add the metrics pipeline
binding:
  - id: metrics
    links:
      '/pipeline/system::metrics/system/out':  ["/offramp/system::stdout/system/in"]

Notes

Output of rustup --version:
Output of rustup show:
Output of tremor-server --version: tremor:0.7.4-alpha

@rajasimha1991 rajasimha1991 added the bug Something isn't working label Apr 30, 2020
@Licenser
Copy link
Member

As part of the optimizations in the version of 0.7 and beyond we are culling nodes of the executable graph that have no impact on the pipeline. The in node for pipelines is one of those nodes. As an alternative, the onramps now include metrics, where the same value can be read from @anupdhml, can elaborate on that.

If that works for you I think we can close that otherwise, it'd be great to understand what problem you're trying to solve and see how we can solve that best.

@Licenser
Copy link
Member

Licenser commented Aug 4, 2020

@anupdhml @rajasimha1991 can we close this issue?

@anupdhml
Copy link
Contributor

anupdhml commented Aug 6, 2020

Yes, the onramp metrics work for the need here and since the in node was never part of the pipeline config explicitly, it makes sense for metrics for it to be not present now. Chatted about this with Raj too over slack and he is fine with closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants