Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Click events on charts #711

Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat: Click events on charts #711

merged 2 commits into from
Sep 25, 2023

Conversation

severinlandolt
Copy link
Member

Description

This PR adds:

This PR fixes:

  • Tab: Improved styling and padding on the solid variant. fix: Improve styling in <Tabs> for variant solid #674
  • Area Chart, Line Chart, Bar Chart, Scatter Chart, Donut Chart: Changed default setting: Prop showAnimation is now false.
  • Area Chart, Line Chart, Bar Chart, Scatter Chart, Donut Chart: Fixed border color bug in dark mode fix: Correct classname spelling #698
  • Area Chart, Line Chart, Bar Chart, Scatter Chart: Gridlines are now solid, not dotted. Also, the color changed from tremor-border to tremor-content-subtle
  • Button: Added cursor-not-allowed to disabled state.
  • ProgressBar: Changed background color from tremor-brand-faint to tremor-brand-muted

Related issue(s)

#195 #381

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

Added new Storybook stories.

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • [] Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

severinlandolt and others added 2 commits September 24, 2023 15:52
Co-authored-by: jzfrank <77217626+jzfrank@users.noreply.github.com>
Co-authored-by: mbauchet <maximebauchet26@gmail.com>
Co-authored-by: Thomas McInnis <hey@thomasmcinnis.com>
Co-authored-by: Manav H Joshi <73978411+ManavJoshi111@users.noreply.github.com>
@christopherkindl christopherkindl merged commit f4d77bb into main Sep 25, 2023
5 checks passed
@github-actions
Copy link

🎉 This PR is included in version 3.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants