Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send ETH (EVM) #3858

Closed
Hannsek opened this issue May 24, 2024 · 3 comments · Fixed by #4095 or #4143
Closed

Send ETH (EVM) #3858

Hannsek opened this issue May 24, 2024 · 3 comments · Fixed by #4095 or #4143
Assignees
@ibz
Labels
T3T1
Milestone
T3T1

Comments

@Hannsek
Copy link
Contributor

Hannsek commented May 24, 2024

Design: Figma
@Hannsek Hannsek added the T3T1 label May 24, 2024
@Hannsek Hannsek added this to the T3T1 milestone May 24, 2024
@ibz ibz mentioned this issue Aug 8, 2024
Merged
@ibz ibz pinned this issue Aug 8, 2024
@ibz ibz unpinned this issue Aug 8, 2024
@ibz
Copy link
Contributor

ibz commented Aug 14, 2024 •
edited
Loading

Note: I am using the standard success screen, which looks slightly different than the design in Figma.

(success animation)

image

(success, after animation ends)

image

Also, the progress screen is slightly different too.

@obrusvit
Copy link
Contributor

@ibz yes, use the current implementation of success screen. They can fit more text.
Figma success screens are a little bit outdated.

@Hannsek Hannsek linked a pull request Aug 17, 2024 that will close this issue
feat(core): improve ETH send flow. #4095
Merged
@ibz ibz closed this as completed in #4095 Aug 27, 2024
@ibz ibz linked a pull request Sep 3, 2024 that will close this issue
feat(core): use new ETH send flow also for staking #4143
Merged
@ibz
Copy link
Contributor

ibz commented Sep 3, 2024

BTW, I reused this new flow also for the staking part, which now looks more like the Figma: https://www.figma.com/design/n43caWJFGJlT167AQcxruu/%E3%80%94-Prod-%E3%80%95Safe-5?node-id=160-368&node-type=CANVAS&t=q6Wjn67DNiTujwTm-0

Linked the relevant PR to this issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibz ibz

Labels
T3T1
Projects
Firmware
Status: 🎯 To do
Milestone
T3T1
3 participants
@ibz @obrusvit @Hannsek