Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost.m4 check for boost_thread dependency for boost_context broken #117

Open
James-TR opened this issue Oct 25, 2019 · 3 comments
Open
Assignees

Comments

@James-TR
Copy link

The boost.m4 check for linking boost_thread to boost_context is incorrect, as this isn't linked where is available. The first release to change this behaviour is 1.61.0

Here's the relevant commit:
boostorg/context@01d3c90

Here's the relevant lines in the 1.71.0 release of boost_context:
https://github.com/boostorg/context/blob/boost-1.71.0/build/Jamfile.v2#L783-L789

@James-TR
Copy link
Author

@James-TR
Copy link
Author

I've found an example of how to check for the mutex std::call_once here https://github.com/cburschka/lyx/blob/44bbd0b0ef8450f4d88dfb8c3345118f2fd14dfc/config/lyxinclude.m4#L252-L275

@pieterlexis pieterlexis self-assigned this Dec 10, 2019
@James-TR
Copy link
Author

Just thought I would clarify that the current check will still be required for versions from 157 -> 160 as BOOST::THREAD was blindly included. From 161 and above the check was fixed to implement the check for mutex std::call_once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants