Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix_hci adapter: uninitialized file descriptor with Python 2 #108

Closed
mwiercinski opened this issue Apr 24, 2020 · 1 comment · Fixed by #109
Closed

nix_hci adapter: uninitialized file descriptor with Python 2 #108

mwiercinski opened this issue Apr 24, 2020 · 1 comment · Fixed by #109

Comments

@mwiercinski
Copy link

DEVNULL is only initialized with Python 3. In case of the old version it attempts to reference uninitialized variable.

ruuvitag-sensor/ruuvitag_sensor/adapters/nix_hci.py

Line 30 in b7d2fc2

DEVNULL = subprocess.DEVNULL

@ttu ttu mentioned this issue Apr 24, 2020
Merged
@ttu
Copy link
Owner

ttu commented Apr 24, 2020

Thanks for the issue!

Apparently check had broken during some refactoring. Changed it back to original.

This time also executed verification test with Python 2, so should work. Will release a fixed version soon.

@ttu ttu closed this as completed in #109 Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix DEVNULL initialization when using Python 2 ttu/ruuvitag-sensor
2 participants
@ttu @mwiercinski