Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data format 3 decoding is not working with Python2 #9

Closed
Jussihoo opened this issue Apr 30, 2017 · 2 comments
Closed

Data format 3 decoding is not working with Python2 #9

Jussihoo opened this issue Apr 30, 2017 · 2 comments

Comments

@Jussihoo
Copy link

There is this line of code in the decoder.py (line 124) which does not work with python2

byte_data = bytes.fromhex(data)

It works when changed as:
byte_data = bytearray.fromhex(data)

I suppose this would work also with python3 so you might want to consider making this change?

Thanks for the great library!
@ttu
Copy link
Owner

ttu commented May 3, 2017

Thanks for the change recommendation. Changed byte to bytearray fed8b0c

@ttu
Copy link
Owner

ttu commented May 5, 2017

Merged to master (#12) and released with version 0.6.0

@ttu ttu closed this as completed May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ttu @Jussihoo