Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal remote is not showed properly #10578

Closed
jluisram opened this issue Sep 11, 2013 · 3 comments
Closed

Modal remote is not showed properly #10578

jluisram opened this issue Sep 11, 2013 · 3 comments

Comments

@jluisram
Copy link

There is something missing in javascript after 3.0.0-rc1, versions -rc2 -wip and the latest release.

It shows a transparent background in modals when loads a single html file as remote content. There is a similar bug #10415, but this one is not related with Rails.

<html>
<head>
  <link rel="stylesheet" href="//netdna.bootstrapcdn.com/bootstrap/3.0.0/css/bootstrap.min.css"/>
</head>
<body>
  <a href="#myModal" data-toggle="modal" class="btn btn-primary btn-lg">Launch demo modal</a>
  <a href="./test.html" data-toggle="modal" data-target="#myModal2" class="btn btn-primary btn-lg">Launch demo modal2</a>
  <!-- Modal -->
  <div class="modal fade" id="myModal" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true">
    <div class="modal-dialog">
      <div class="modal-content">
        <div class="modal-header">
          <button type="button" class="close" data-dismiss="modal" aria-hidden="true">×</button>
          <h4 class="modal-title">Modal title</h4>
        </div>
        <div class="modal-body">
          ...
        </div>
        <div class="modal-footer">
          <button type="button" class="btn btn-default" data-dismiss="modal">Close</button>
          <button type="button" class="btn btn-primary">Save changes</button>
        </div>
      </div><!-- /.modal-content -->
    </div><!-- /.modal-dialog -->
  </div><!-- /.modal -->
  <!-- Modal -->
  <div class="modal fade" id="myModal2" tabindex="-1" role="dialog" aria-labelledby="myModalLabel" aria-hidden="true">
    <div class="modal-dialog">
      <div class="modal-content">
        <div class="modal-header">
          <button type="button" class="close" data-dismiss="modal" aria-hidden="true">×</button>
          <h4 class="modal-title">Modal title</h4>
        </div>
        <div class="modal-body">
          ...
        </div>
        <div class="modal-footer">
          <button type="button" class="btn btn-default" data-dismiss="modal">Close</button>
          <button type="button" class="btn btn-primary">Save changes</button>
        </div>
      </div><!-- /.modal-content -->
    </div><!-- /.modal-dialog -->
  </div><!-- /.modal -->
<script src="//code.jquery.com/jquery.js"></script>
<!--
it only works well in 2.3.2 and 3.0.0-rc1 javascript, any other version shows transparent background 
 //netdna.bootstrapcdn.com/bootstrap/3.0.0-rc1/js/bootstrap.min.js
 //netdna.bootstrapcdn.com/bootstrap/3.0.0-rc2/js/bootstrap.min.js
 //netdna.bootstrapcdn.com/bootstrap/3.0.0-wip/js/bootstrap.min.js
-->
<script src="//netdna.bootstrapcdn.com/bootstrap/3.0.0/js/bootstrap.min.js"></script>
</body>
</html>

It fails in MAC OSX 10.8.4 and Windows 7 Professional, in Safari 6.0.5, Firefox 23.0.1, Google Chrome 29.0.1547.65 and Internet Explorer 10.0.9200.16686.

@cvrebert
Copy link
Collaborator

Have you accounted for the change made in #9318?

@jluisram
Copy link
Author

Of course, you can add the entire div.modal-dialog in every target file or use the first release candidate or version 2.3.2. But, I understand than 9318 is a request to load content in div.modal-content to customize header and footer, in that case I would recommend to use a plugin and not to modify the default behaviour.

@cvrebert
Copy link
Collaborator

@jluisram The request in #9318 was granted. The default behavior has been changed in the final release version of v3.0.0. Please modify your pages accordingly.

Although honestly, I don't recommend using remote at all, because it's so limited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants