-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
role="navigation" in navbars is redundant since they use <nav>? #15109
Comments
That's correct. The HTML5 spec even states (emphasis mine):
Source: http://www.w3.org/TR/html5/sections.html#the-nav-element. |
LGTM |
Voice-over don't provide navigation landmark if you remove role="navigation" inside nav. Tested with safari, voice-over, OSX This website says also NVDA : |
Recent bug in VO/OS X (VO/iOS recognises IE/NVDA is a long-standing bug. Further discussion here bab3622#commitcomment-9712024 |
OSX/VO chrome canary, chrome, FF, FF dev edition => OK, landmark listed Safari Version 7.1.3 (9537.85.12.18) - OSX version 10.9.5 (mavericks)
It look like it's a bug in Safari. |
thanks for further testing. yeah, once I get a second, I'll start pestering Apple devs with a bug report... |
All the navbars in the docs examples use
<nav>
rather than<div>
, which I believe means that theirrole="navigation"
attributes are redundant.So we might be able to remove the
role="navigation"
s and adjust this callout to advocate for using<nav>
s as opposed to includingrole="navigation"
s.CC: @patrickhlauke
The text was updated successfully, but these errors were encountered: