Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporal date inputs on iOS not aligned if inside of .input-group-lg #15413

Closed
niftylettuce opened this issue Dec 19, 2014 · 5 comments
Closed
Labels
Milestone

Comments

@niftylettuce
Copy link

currently the CSS rule is here

bootstrap/less/forms.less

Lines 184 to 189 in 10e9fef

&.input-sm {
line-height: @input-height-small;
}
&.input-lg {
line-height: @input-height-large;
}

we need to account for if the input is nested inside of an .input-group-lg or .input-group-sm

@juthilo juthilo added the css label Dec 19, 2014
@mdo
Copy link
Member

mdo commented Dec 21, 2014

The block you're referring to has since been replaced: https://github.com/twbs/bootstrap/blob/master/less/forms.less#L168:L194. As far as I can tell, there's no longer an issue.

@mdo mdo closed this as completed Dec 21, 2014
@niftylettuce
Copy link
Author

@mdo @juthilo please re-open, it looks like it still might be an issue, shouldn't we add this since it's missing right now?

@media screen and (-webkit-min-device-pixel-ratio: 0) {
  .input-group-lg {
    input[type="date"],
    input[type="time"],
    input[type="datetime-local"],
    input[type="month"] {
      line-height: @input-height-large;
    }
  }
  .input-group-sm {
    input[type="date"],
    input[type="time"],
    input[type="datetime-local"],
    input[type="month"] {
      line-height: @input-height-small;
    }
  }
}

@niftylettuce
Copy link
Author

submitting a pull request now...

@cvrebert
Copy link
Collaborator

Fixed by c41970c.

@niftylettuce
Copy link
Author

@cvrebert thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants