Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS _variables.scss file has misspelled variable: heading-color (node package) #36847

Closed
3 tasks done
UAK-35 opened this issue Jul 26, 2022 · 1 comment · Fixed by #36849
Closed
3 tasks done

SCSS _variables.scss file has misspelled variable: heading-color (node package) #36847

UAK-35 opened this issue Jul 26, 2022 · 1 comment · Fixed by #36849

Comments

@UAK-35
Copy link

UAK-35 commented Jul 26, 2022

Prerequisites

Describe the issue

The current version (5.2.0) SCSS _variables.scss file has following statement at line 1363:
$popover-header-color: var(--#{$prefix}heading-color) !default;

It should be as follows:
$popover-header-color: var(--#{$prefix}headings-color) !default;

Note the s just before hyphen right before the word color, and I have used node to install bootstrap using following command:
npm i bootstrap

The effect of this bug is that dart-sass still compiles this file successfully but $popover-header-color variable has no value.

Thanks.

Reduced test cases

You can change line 1363 as follows:
$popover-header-color: $heading-color !default;

and it will not compile. It should be as below to compile sucessfully:
$popover-header-color: $headings-color !default;

Note the s just before hyphen right before the word color.

What operating system(s) are you seeing the problem on?

Linux

What browser(s) are you seeing the problem on?

Firefox

What version of Bootstrap are you using?

v5.2.0

@julien-deramond
Copy link
Member

Thanks for reporting this issue @UAK-35! You're right --#{$prefix}heading-color isn't defined anymore anywhere due to recent changes. I've created a PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants