Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore template only base on filename not an full path #638

Closed
adiroiban opened this issue Jul 31, 2024 · 1 comment · Fixed by #639
Closed

Ignore template only base on filename not an full path #638

adiroiban opened this issue Jul 31, 2024 · 1 comment · Fixed by #639

Comments

@adiroiban
Copy link
Member 

          This is not ok.

We should extract the filename from the filepath.

Originally posted by @adiroiban in #633 (comment)
@adiroiban
Copy link
Member Author

@aviramha I will try to create a PR with a fix for this.

it would help if you could review the future PR

@adiroiban adiroiban mentioned this issue Jul 31, 2024
Merged
@adiroiban adiroiban mentioned this issue Aug 5, 2024
Closed
This was referenced Aug 11, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 18, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for ignoring the template based only on filename. twisted/towncrier
1 participant
@adiroiban