Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show vX.Y+something for dev versions #2254

Closed
jayvdb opened this issue Aug 10, 2022 · 2 comments · Fixed by #2255
Closed

Show vX.Y+something for dev versions #2254

jayvdb opened this issue Aug 10, 2022 · 2 comments · Fixed by #2255
Labels
enhancement New feature or request

Comments

@jayvdb
Copy link

jayvdb commented Aug 10, 2022

Is your feature request related to a problem? Please describe.

I first installed chezmoi using guix, and its build shows version "dev". i.e.

$ chezmoi --version
chezmoi version dev

It was mentioned on the installation guide so I assumed this would be a recent version. Turns out guix show chezmoi shows 1.8.1.

IMO it would be a good idea to remove guix since it is unmaintained, or at least link to/ use data from https://repology.org/project/chezmoi/versions to help inform people of which package manager they may wish to avoid.

I then built it locally from git, and found it also shows "dev" as the version.

Describe the solution you'd like

At least for git builds, which are easy to detect, it would be good to have the version number + sha, i.e. v2.20.0+892c584

Describe alternatives you've considered

Another pattern which is common is the most recent tag name followed by the number of commits since that tag, i.e. v2.20.0-NEXT.20

@jayvdb jayvdb added the enhancement New feature or request label Aug 10, 2022
@jayvdb
Copy link
Author

jayvdb commented Aug 10, 2022

Ugh, I see the Makefile has support for this as install-from-git-working-copy , which isn't mentioned on https://www.chezmoi.io/install/#install-from-source

@twpayne
Copy link
Owner

twpayne commented Aug 12, 2022

Thanks for this, I've created #2255 to update the docs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants