-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New versions trigger no saslprep warnings #807
Comments
are you sure MMS is the problem here? because to my knowledge this warning only gets printed for mongodb 5.8 and up and MMS 8.x uses mongodb driver 4.x, which should not have this warning. and from what i can gather mongodb 5.8.0 had a problem that was introduced via:
but fixed with 5.8.1:
MMS 9 will ship with mongodb 5.9.0 maybe check your lockfile / requirements of
i have no clue what could cause this problem, and without specifics i cannot help with that |
Thanks for answering @hasezoey!
I'm pretty sure, I tested this multiple times by upgrading and downgrading Regarding the jest issue, I meant to share why I don't want to install |
well that is weird, i cannot reproduce this and dont know how this could happen, maybe try mongodb-memory-server 9.0.0? (just released) |
@hasezoey Unfortunately, upgrading to 9.0.0 did not fix the issue.
I do not have any explicit auth configuration, but this did not remove the warning. |
i dont know if you are using authentication so it may not impact you, before 9.0.0 authentication was enabled if also MMS 9.0.0 uses mongodb 5.9.0, which does not cause this anymore (a newer 4.x version did also not cause this anymore, from what i can tell), so try to inspect your dependency tree and see where that problematic version of mongodb is still installed (ex |
@hasezoey Here is the output of The production dependency that I use to interact with the DB hosted on Atlas is |
@nicolassanmar your issue seems to be quite simple: you have the old MMS version installed through
if that still does not solve the issue, you probably need to upgrade all the dependencies that use mongodb 4.x to 5.x (or try the latest 4.x available, which at current is 4.17.1) note: to my knowledge the mongodb version which introduced the saslprep warning is |
@hasezoey Thanks for your multiple suggestions, and the helpful back and forth. |
Versions
package: mongo-memory-server
What is the Problem?
Upgrading from
8.10.2
to8.16.0
causes my Vercel deployments to print a warning every time a connection is made tomongodb
even thoughmongodb-memory-server
is a dev dependency. The warning states:Warning: no saslprep library specified. Passwords will not be sanitized
. I confirmed this is caused by updating the library via testing multiple deployments with just amongo-memory-server
update.The warning goes away after installing
saslprep
as a dev dependency, but that has two downsides:saslprep
as I don't really use itNot really sure why these dev dependencies change how the Vercel deployement behaves, but any help is appreciated.
The text was updated successfully, but these errors were encountered: