Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support raw git hook names as npm scripts #94

Closed
julien-f opened this issue Jan 16, 2017 · 3 comments
Closed

Support raw git hook names as npm scripts #94

julien-f opened this issue Jan 16, 2017 · 3 comments

Comments

@julien-f
Copy link
Contributor

Hi,

I was previously using ghooks which used the raw names for git hooks (commit-msg instead of commitmsg).

I can understand your preference of removing - as it's closer to npm standard scripts but it would make the transition from ghooks easier the raw names were also supported.
Furthermore, I think it's clearer to use the git names because that's what one can find on the Internet.

Plus, I must say that, in my opinion, commit-msg is easier to read than commitmsg. :)

@vovacodes
Copy link

There is another issue with the current hook names. Say you have an npm script called commit, then if you define a husky hook "precommit" and run npm run commit npm will also automatically execute precommit just because of the way npm-scripts work. Is it possible to workaround this situation without renaming the commit script?

@iamstarkov
Copy link

iamstarkov commented Feb 14, 2017

@wizardzloy there is no way to workaround it right now

@typicode
Copy link
Owner

Closing as next version will use raw names, thanks for the suggestion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants