Skip to content
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.

Commit

Permalink
refactor: rename utils
Browse files Browse the repository at this point in the history
BREAKING CHANGE: rename makeBreakpointsMap with
makeBreakpointsModel
  • Loading branch information
mg901 committed Mar 2, 2019
1 parent cdd1abd commit 6f5ed76
Show file tree
Hide file tree
Showing 36 changed files with 58 additions and 54 deletions.
2 changes: 1 addition & 1 deletion .babelrc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"alias": {
"@calculators": "./src/calculators",
"@convertors": "./src/convertors",
"@make-breakpoints-map": "./src/make-breakpoints-map",
"@make-breakpoints-model": "./src/make-breakpoints-model",
"@models": "./src/models",
"@utils": "./src/utils",
"@utils-public": "./src/utils-public",
Expand Down
2 changes: 1 addition & 1 deletion .flowconfig
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[options]
esproposal.export_star_as=enable
module.name_mapper='@convertors' -> '<PROJECT_ROOT>/src/convertors'
module.name_mapper='@make-breakpoints-map' -> '<PROJECT_ROOT>/src/make-breakpoints-map'
module.name_mapper='@make-breakpoints-model' -> '<PROJECT_ROOT>/src/make-breakpoints-model'
module.name_mapper='@models' -> '<PROJECT_ROOT>/src/models'
module.name_mapper='@utils' -> '<PROJECT_ROOT>/src/utils'
module.name_mapper='@utils-public' -> '<PROJECT_ROOT>/src/utils-public'
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ returns the Maybe type. The associative array is returned

### Features

* **flow:** add type BreakpointsMap ([0f630b2](https://github.com/typographist/core/commit/0f630b2))
* **flow:** add type BreakpointsModel ([0f630b2](https://github.com/typographist/core/commit/0f630b2))

# [6.0.0](https://github.com/typographist/core/compare/v5.1.2...v6.0.0) (2019-01-23)

Expand Down
2 changes: 1 addition & 1 deletion jsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"paths": {
"@calculators/*": ["./calculators/*"],
"@convertors/*": ["./convertors/*"],
"@make-breakpoints-map/*": ["./make-breakpoints-map/*"],
"@make-breakpoints-model/*": ["./make-breakpoints-model/*"],
"@models/*": ["./models/*"],
"@utils/*": ["./utils/*"],
"@utils-public/*": ["./utils-public/*"],
Expand Down
4 changes: 2 additions & 2 deletions src/constants.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// @flow
import type { UserConfig, Breakpoint, BreakpointsMap } from '@models';
import type { UserConfig, Breakpoint, BreakpointsModel } from '@models';

export const HALF = 0.5;
export const BROWSER_VIEWPORT_WIDTH = '100vw';
Expand All @@ -21,7 +21,7 @@ export const DEFAULT_CONFIG: UserConfig = {
ratio: 1.333,
};

export const DEFAULT_BREAK_MAP: BreakpointsMap = {
export const DEFAULT_BREAK_MAP: BreakpointsModel = {
default: {
base: [16],
lineHeight: 1.5,
Expand Down
8 changes: 4 additions & 4 deletions src/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// @flow

export { makeBreakpointsMap } from '@make-breakpoints-map';
export { makeBreakpointsModel } from '@make-breakpoints-model';
export * as constants from '@constants';
export { percentage } from '@convertors/percentage';
export { toEm } from '@convertors/to-em';
Expand All @@ -13,13 +13,13 @@ export { toCebabCase } from '@utils-public/to-cebab-case';
export { toRem } from '@utils-public/to-rem';
export { toSnakeCase } from '@utils-public/to-snake-case';
export {
getBreaksWithoutDefault,
getBreakNames,
getTailBreaksValues,
getTailBreaksNames,
makeBreakNamesRow,
makeBreakpoints,
getDefaultBreak,
} from '@utils-public/breakpoints';
export type { BreakpointsMap, Breakpoint } from '@models/breakpoints';
export type { BreakpointsModel, Breakpoint } from '@models/breakpoints';
export type { UserConfig } from '@models/user-config';

export const ratios = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
import memoizeone from 'memoize-one';
import { validateUserConfig } from '@validate-user-config';
import { type UserConfig } from '@models/user-config';
import { type BreakpointsMap } from '@models/breakpoints';
import { makeBreakpointsProcess } from './make-breakpoints-process';
import { type BreakpointsModel } from '@models/breakpoints';
import { makeBreakpointsProcess } from './make-breakpoints-model-process';

const memoizedMakeBreakpoints: (UserConfig) => BreakpointsMap = memoizeone(
const memoizedMakeBreakpoints: (UserConfig) => BreakpointsModel = memoizeone(
makeBreakpointsProcess,
);

/* eslint-disable consistent-return */
export const makeBreakpointsMap: (UserConfig) => * = (config) => {
export const makeBreakpointsModel: (UserConfig) => * = (config) => {
if (validateUserConfig(config)) {
return memoizedMakeBreakpoints(config);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ import { setPropRoot } from './root-prop-utils';
import { makeBreakMap } from './make-break-map';
import type {
UserConfig,
BreakpointsMap,
BreakpointsModel,
NotFilledNamedBreak,
NotFilledRenamedBreak,
} from '../models';

export const makeBreakpointsProcess: (UserConfig) => BreakpointsMap = R.compose(
export const makeBreakpointsProcess: (UserConfig) => BreakpointsModel = R.compose(
R.compose(
R.map(R.omit(['name'])),
R.reduce(makeBreakMap, {}),
Expand Down
8 changes: 6 additions & 2 deletions src/mocks.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
// @flow

import type { UserConfig, BreakpointWithName, BreakpointsMap } from './models';
import type {
UserConfig,
BreakpointWithName,
BreakpointsModel,
} from './models';

export const userConfig: UserConfig = {
base: ['1em', '2em'],
Expand Down Expand Up @@ -69,7 +73,7 @@ export const breakpoints: BreakpointWithName[] = [
},
];

export const breakpointsMap: BreakpointsMap = {
export const breakpointsModel: BreakpointsModel = {
default: {
base: [16, 32],
lineHeight: 1.5,
Expand Down
4 changes: 2 additions & 2 deletions src/models/__mocks__/breakpoints.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// @flow

import type { BreakpointWithName, BreakpointsMap } from '../breakpoints';
import type { BreakpointWithName, BreakpointsModel } from '../breakpoints';

export const breakpoints: BreakpointWithName[] = [
{
Expand Down Expand Up @@ -45,7 +45,7 @@ export const breakpoints: BreakpointWithName[] = [
},
];

export const breakpointsMap: BreakpointsMap = {
export const breakpointsModel: BreakpointsModel = {
default: {
base: [16, 32],
lineHeight: 1.5,
Expand Down
2 changes: 1 addition & 1 deletion src/models/breakpoints.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export type Breakpoint = {|
root: number,
|};

export type BreakpointsMap = {
export type BreakpointsModel = {
[string]: Breakpoint,
};

Expand Down
16 changes: 8 additions & 8 deletions src/utils-public/breakpoints.js
Original file line number Diff line number Diff line change
@@ -1,35 +1,35 @@
// @flow

import * as R from 'ramda';
import { getBreaksMapOr } from '@utils/get-breaks-map-or';
import { getBreaksModelOrDefaultModel } from '@utils/get-breaks-model-or-default-model';
import { headOr } from '@utils/head-or';
import type {
BreakpointsMap,
BreakpointsModel,
UserConfig,
Breakpoints,
Breakpoint,
} from '@models';

export const getBreaksWithoutDefault: (BreakpointsMap) => * = R.compose(
export const getTailBreaksValues: (BreakpointsModel) => * = R.compose(
R.tail,
R.values,
);

export const getBreakNames: (BreakpointsMap) => string[] = R.compose(
export const getTailBreaksNames: (BreakpointsModel) => string[] = R.compose(
R.tail,
R.keys,
);

export const makeBreakNamesRow = (breaksMap: BreakpointsMap) =>
`'${getBreakNames(breaksMap).join(', ')}'`;
export const makeBreakNamesRow = (breaksMap: BreakpointsModel) =>
`'${getTailBreaksNames(breaksMap).join(', ')}'`;

export const makeBreakpoints: (UserConfig) => Breakpoints = R.compose(
R.dissoc('default'),
R.map(R.prop('value')),
getBreaksMapOr,
getBreaksModelOrDefaultModel,
);

export const getDefaultBreak: (BreakpointsMap) => Breakpoint = R.compose(
export const getDefaultBreak: (BreakpointsModel) => Breakpoint = R.compose(
headOr,
R.values,
);
9 changes: 0 additions & 9 deletions src/utils/get-breaks-map-or.js

This file was deleted.

9 changes: 9 additions & 0 deletions src/utils/get-breaks-model-or-default-model.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import type { UserConfig } from '@models';
import * as R from 'ramda';
import { DEFAULT_BREAK_MAP } from '@constants';
import { makeBreakpointsModel } from '@make-breakpoints-model';

export const getBreaksModelOrDefaultModel: (UserConfig) => * = R.compose(
R.defaultTo(DEFAULT_BREAK_MAP),
makeBreakpointsModel,
);
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { basePropProcess } from '@make-breakpoints-map/base-prop-process';
import { basePropProcess } from '@make-breakpoints-model/base-prop-process';

describe('basePropProcess', () => {
it('breakpoint object with a base key containing an array of numbers', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createBreakpoints } from '@make-breakpoints-map/create-breakpoints';
import { createBreakpoints } from '@make-breakpoints-model/create-breakpoints';
import { userConfig } from '@mocks';

describe('createBreakpoints', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { userConfig } from '@mocks';
import { makeBreakpointsMap } from '@make-breakpoints-map';
import { makeBreakpointsModel } from '@make-breakpoints-model';

describe('makeBreakpointsMap', () => {
describe('makeBreakpointsModel', () => {
it('create a list of breakpoint values if the user config is valid', () => {
expect(makeBreakpointsMap(userConfig)).toEqual({
expect(makeBreakpointsModel(userConfig)).toEqual({
default: {
base: [16, 32],
lineHeight: 1.5,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { inheritProps } from '@make-breakpoints-map/inherit-props';
import { inheritProps } from '@make-breakpoints-model/inherit-props';

describe('inheritProps', () => {
it('inherits all missing key values', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { makeBreakMap } from '@make-breakpoints-map/make-break-map';
import { makeBreakMap } from '@make-breakpoints-model/make-break-map';
import { breakpoints } from '@mocks';

describe('makeBreaksMap', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { makeBreakpointsProcess } from '@make-breakpoints-map/make-breakpoints-process';
import { userConfig, breakpointsMap } from '@mocks';
import { makeBreakpointsProcess } from '@make-breakpoints-model/make-breakpoints-model-process';
import { userConfig, breakpointsModel } from '@mocks';

describe('makeBreakpointsProcess', () => {
it('returns the breakpoints map', () => {
expect(makeBreakpointsProcess(userConfig)).toEqual(breakpointsMap);
expect(makeBreakpointsProcess(userConfig)).toEqual(breakpointsModel);
});

it('returns the breakpoint model from default user config', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { makeDefaultBreak } from '@make-breakpoints-map/make-default-break';
import { makeDefaultBreak } from '@make-breakpoints-model/make-default-break';
import { userConfig } from '@mocks';

describe('makeDefaultBreak', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { makeNamedBreaks } from '@make-breakpoints-map/make-named-breaks';
import { makeNamedBreaks } from '@make-breakpoints-model/make-named-breaks';
import { userConfig } from '@mocks';

describe('makeNamedBreaks', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {
makeFontSizeFromLiteral,
calcRatio,
calcRatioProcess,
} from '@make-breakpoints-map/ratio-prop-utils';
} from '@make-breakpoints-model/ratio-prop-utils';

const ratioLiteral = '45px at 6';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { renameProp } from '@make-breakpoints-map/rename-prop';
import { renameProp } from '@make-breakpoints-model/rename-prop';

describe('renameProp', () => {
it('return object with ranamed prop', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {
calcRoot,
setPropRoot,
} from '@make-breakpoints-map/root-prop-utils';
} from '@make-breakpoints-model/root-prop-utils';

describe('calcRoot', () => {
it('calculated int root', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { toPxBreakValue } from '@make-breakpoints-map/to-px-break-value';
import { toPxBreakValue } from '@make-breakpoints-model/to-px-break-value';

describe('toPxBreakValue', () => {
it('returns the breakpoints value converted from em to px', () => {
Expand Down

0 comments on commit 6f5ed76

Please sign in to comment.