Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] NRC Q #34

Closed
joepie91 opened this issue Jan 18, 2016 · 2 comments
Closed

[request] NRC Q #34

joepie91 opened this issue Jan 18, 2016 · 2 comments

Comments

@joepie91
Copy link

@Zegnat
Copy link

Zegnat commented Jan 21, 2016

I can put in a pull request for this when I get home. /advertorial/ seems to be a popular path addition in the Netherlands. Basically, just copy these adformatie.nl rules and match them against nrcq.nl:

  'nrcq.nl': [
    {
      example: 'http://www.nrcq.nl/advertorial/vergeet-wie-ik-ben-dat-moet-van-de-nieuwe-privacywet',
      match: function() {
        return urlContains('/advertorial/');
      },
    },
  ],

@typpo
Copy link
Owner

typpo commented Jan 29, 2016

PR #35 should solve this issue. Thank you for the help!

Note that this won't go out til the extension itself is updated, which will happen soon(ish).

@typpo typpo closed this as completed Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants