Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bb: be more specific in module dependency message #58

Merged
merged 2 commits into from
Dec 30, 2021
Merged

bb: be more specific in module dependency message #58

merged 2 commits into from
Dec 30, 2021

Conversation

hugelgupf
Copy link
Member

before:

2021/12/29 21:31:25 Conflicting module dependencies on github.com/u-root/u-root:
2021/12/29 21:31:25   module github.com/u-root/cpu depends on it @ version v0.8.0
2021/12/29 21:31:25   your request to compile github.com/u-root/u-root/cmds/core/ip depends on it @ directory /usr/local/google/home/chrisko/go/src/github.com/u-root/u-root

2021/12/29 21:31:25 Suggestion to resolve: add `replace github.com/u-root/u-root => ../go/src/github.com/u-root/u-root` to /usr/local/google/home/chrisko/cpu/go.mod

after:

2021/12/29 21:31:25 Conflicting module dependencies on github.com/u-root/u-root:
2021/12/29 21:31:25   module github.com/u-root/cpu depends on github.com/u-root/u-root @ version v0.8.0
2021/12/29 21:31:25   your request to compile github.com/u-root/u-root/cmds/core/ip depends on github.com/u-root/u-root @ directory /usr/local/google/home/chrisko/go/src/github.com/u-root/u-root

2021/12/29 21:31:25 Suggestion to resolve: add `replace github.com/u-root/u-root => ../go/src/github.com/u-root/u-root` to /usr/local/google/home/chrisko/cpu/go.mod

@hugelgupf
bb: be more specific in module dependency message
6d89180 
before:

2021/12/29 21:31:25 Conflicting module dependencies on github.com/u-root/u-root:
2021/12/29 21:31:25   module github.com/u-root/cpu depends on it @ version v0.8.0
2021/12/29 21:31:25   your request to compile github.com/u-root/u-root/cmds/core/ip depends on it @ directory /usr/local/google/home/chrisko/go/src/github.com/u-root/u-root

2021/12/29 21:31:25 Suggestion to resolve: add `replace github.com/u-root/u-root => ../go/src/github.com/u-root/u-root` to /usr/local/google/home/chrisko/cpu/go.mod

after:

2021/12/29 21:31:25 Conflicting module dependencies on github.com/u-root/u-root:
2021/12/29 21:31:25   module github.com/u-root/cpu depends on github.com/u-root/u-root @ version v0.8.0
2021/12/29 21:31:25   your request to compile github.com/u-root/u-root/cmds/core/ip depends on github.com/u-root/u-root @ directory /usr/local/google/home/chrisko/go/src/github.com/u-root/u-root

2021/12/29 21:31:25 Suggestion to resolve: add `replace github.com/u-root/u-root => ../go/src/github.com/u-root/u-root` to /usr/local/google/home/chrisko/cpu/go.mod

Signed-off-by: Chris Koch <chrisko@google.com>
@hugelgupf hugelgupf force-pushed the improve-error-msg branch 2 times, most recently from c969f38 to 5db9831 Compare December 30, 2021 21:06
@hugelgupf
bb: pass around a logger rather than using log.Printf
2043a54 
Signed-off-by: Chris Koch <chrisko@google.com>
@hugelgupf hugelgupf merged commit 8219da9 into u-root:main Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hugelgupf