findpkg: support for globs, GBB_PATH, UROOT_SOURCE #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugelgupf
force-pushed
the
glob-support
branch
3 times, most recently
from
327fc92
to
d80e6d6
Compare
Signed-off-by: Chris Koch <chrisko@google.com>
hugelgupf
force-pushed
the
glob-support
branch
7 times, most recently
from
dee318b
to
b067ba9
Compare
hugelgupf
force-pushed
the
glob-support
branch
8 times, most recently
from
032faa5
to
47882f6
Compare
hugelgupf
changed the title
hugelgupf
force-pushed
the
glob-support
branch
from
47882f6
to
6235675
Compare
Raises gobusybox's requirements to Go 1.15 due to some package query logic using packages.Load (sometimes, underlying semantics of packages.Load change from Go version to Go version). Considerable effort was taken here to reduce the amount of time it takes to query and glob a larger amount of packages. A lot of code deals with batching packages.Load calls where possible in order to reduce time taken. Signed-off-by: Chris Koch <chrisko@google.com>
GBB_PATH allows providing directories in which to look for Go commands. For example, GBB_PATH=$HOME/u-root and pattern=[cmds/core/init, cmds/core/ip] will look for Go commands in $HOME/u-root/cmds/core/init and $HOME/u-root/cmds/core/ip. Multiple GBB_PATHs can be given; they must be colon-separated. UROOT_SOURCE is supported to provide backwards-compatibility with the u-root command line tool which supported the concept. It's similar to GBB_PATH, but special to github.com/u-root/u-root. Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
hugelgupf
force-pushed
the
glob-support
branch
2 times, most recently
from
d3d2c62
to
fd65dc9
Compare
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
not parsed. Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
The arguments to packages.Config, the specific stuff being gathered, is the exact set of dependencies necessary for busybox. If we wanted to expose a generic API for gathering []*packages.Package, we'd have to allow users to pass their own Config. Let's not go that far. Signed-off-by: Chris Koch <chrisko@google.com>
hugelgupf
force-pushed
the
glob-support
branch
from
fd65dc9
to
747cd5a
Compare
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
hugelgupf
force-pushed
the
glob-support
branch
from
747cd5a
to
7777fcc
Compare
Test case can only be run with GO111MODULE=on for NewPackage, unless we add golang.org/x/sys/unix to GOPATH in the test environment. Signed-off-by: Chris Koch <chrisko@google.com>
hugelgupf
force-pushed
the
glob-support
branch
2 times, most recently
from
2a6722c
to
1b593a8
Compare
Depends on u-root commands as well as u-root module, both of which require Go 1.16 Signed-off-by: Chris Koch <chrisko@google.com>
hugelgupf
force-pushed
the
glob-support
branch
3 times, most recently
from
fbe5580
to
8870f8c
Compare
[skip ci] Signed-off-by: Chris Koch <chrisko@google.com>
[skip ci] Signed-off-by: Chris Koch <chrisko@google.com>
hugelgupf
force-pushed
the
glob-support
branch
from
54f9a7c
to
158e225
Compare
This was referenced Dec 29, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok github.com/u-root/gobusybox/src/pkg/bb/findpkg 33.126s coverage: 97.3% of statements