Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proccall is Broken #9

Closed
btwooton opened this issue Apr 20, 2017 · 1 comment
Closed

Proccall is Broken #9

btwooton opened this issue Apr 20, 2017 · 1 comment
Assignees

Comments

@btwooton
Copy link
Collaborator

Proccall is not written to accommodate NativeProcedure and the newly created PrimitiveProcedure and needs to be augmented to accommodate these types of Procedures. There is also a bug in the evaluation mechanism that seems to be rooted in Proccall_impl. A call to eval::Expression() on (define a 1) returns a DataNode.cdr runtime error on something that is not a pair.

@CinchBlue
Copy link
Contributor

ProcCall now appears to accommodate both NativeProcedure and PrimitiveProcedure and Procedure as well as respect their respective semantics requirements as defined in our local meetings, as of commit 74dc3f3.

One interesting typo is that DataNode.cdr was also the label for the std::runtime_error for car(). So that's unfortunate. That was fixed by that commit as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants