From 7f803c400d40353a0ac6431964f27b5a054d60b6 Mon Sep 17 00:00:00 2001
From: Sam VS <sam.van.stroud@cern.ch>
Date: Thu, 11 Jul 2024 17:56:58 +0100
Subject: [PATCH] Minor update for auxtask plots (#273)

* no colourbar by default

* better ylabel names

* changelog

* revert default, update aux results
---
 changelog.md                |  2 +-
 puma/hlplots/aux_results.py | 15 ++++++++++-----
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/changelog.md b/changelog.md
index 14ee908a..f68affed 100644
--- a/changelog.md
+++ b/changelog.md
@@ -1,7 +1,7 @@
 # Changelog
 
 ### [Latest]
-
+- Minor updates for aux task plots [!273](https://github.com/umami-hep/puma/pull/273)
 - Added better support in yuma, allowing for tau rejection, tau tagging, and Xbb plots [!272](https://github.com/umami-hep/puma/pull/272)
 - Redefined fake rate [!268](https://github.com/umami-hep/puma/pull/268)
 - Removed padded tracks from consideration when generating track origin classification CM [!267](https://github.com/umami-hep/puma/pull/267)
diff --git a/puma/hlplots/aux_results.py b/puma/hlplots/aux_results.py
index fa8b0b9b..17ff85e7 100644
--- a/puma/hlplots/aux_results.py
+++ b/puma/hlplots/aux_results.py
@@ -262,36 +262,40 @@ def plot_var_vtx_perf(
             if isinstance(flavour, str):
                 flav = Flavours[flavour]
 
+            # $n_{vtx}^{match}/n_{vtx}^{true}$
             plot_vtx_eff = VarVsVtxPlot(
                 mode="efficiency",
-                ylabel=r"$n_{vtx}^{match}/n_{vtx}^{true}$",
+                ylabel="Efficiency",
                 xlabel=xlabel,
                 logy=False,
                 atlas_first_tag=self.atlas_first_tag,
                 atlas_second_tag=atlas_second_tag + f", {flav.label}",
                 y_scale=1.4,
             )
+            # $n_{vtx}^{match}/n_{vtx}^{reco}$
             plot_vtx_purity = VarVsVtxPlot(
                 mode="purity",
-                ylabel=r"$n_{vtx}^{match}/n_{vtx}^{reco}$",
+                ylabel="Purity",
                 xlabel=xlabel,
                 logy=False,
                 atlas_first_tag=self.atlas_first_tag,
                 atlas_second_tag=atlas_second_tag + f", {flav.label}",
                 y_scale=1.4,
             )
+            # $n_{trk}^{match}/n_{trk}^{true}$
             plot_vtx_trk_eff = VarVsVtxPlot(
                 mode="efficiency",
-                ylabel=r"$n_{trk}^{match}/n_{trk}^{true}$",
+                ylabel="Track Assignment Efficiency",
                 xlabel=xlabel,
                 logy=False,
                 atlas_first_tag=self.atlas_first_tag,
                 atlas_second_tag=atlas_second_tag + f", {flav.label}",
                 y_scale=1.4,
             )
+            # $n_{trk}^{match}/n_{trk}^{reco}$
             plot_vtx_trk_purity = VarVsVtxPlot(
                 mode="purity",
-                ylabel=r"$n_{trk}^{match}/n_{trk}^{reco}$",
+                ylabel="Track Assignment Purity",
                 xlabel=xlabel,
                 logy=False,
                 atlas_first_tag=self.atlas_first_tag,
@@ -362,7 +366,7 @@ def plot_var_vtx_perf(
 
             plot_vtx_fakes = VarVsVtxPlot(
                 mode="fakes",
-                ylabel=r"$n_{vtx}^{reco}$",
+                ylabel="Vertex Rate",
                 xlabel=xlabel,
                 logy=False,
                 atlas_first_tag=self.atlas_first_tag,
@@ -457,6 +461,7 @@ def plot_track_origin_confmat(
                     ylabel="Target Classes",
                     atlas_second_tag=self.atlas_second_tag,
                     atlas_tag_outside=True,
+                    show_cbar=False,
                     **kwargs,
                 )
             plot_cm.draw(cm)