From 01039cef436353b410d083707d079714f632e9da Mon Sep 17 00:00:00 2001 From: "Shane F. Carr" Date: Thu, 13 Apr 2023 16:20:42 -0700 Subject: [PATCH] Make ScriptDisplayNames be public (#3317) --- experimental/displaynames/src/displaynames.rs | 38 +++++++++---------- experimental/displaynames/src/lib.rs | 1 + .../src/transform/cldr/displaynames/script.rs | 1 + 3 files changed, 21 insertions(+), 19 deletions(-) diff --git a/experimental/displaynames/src/displaynames.rs b/experimental/displaynames/src/displaynames.rs index 64d39466bd1..25cbe7fb6ab 100644 --- a/experimental/displaynames/src/displaynames.rs +++ b/experimental/displaynames/src/displaynames.rs @@ -84,25 +84,25 @@ impl RegionDisplayNames { } } -// / Lookup of the locale-specific display names by script code. -// / -// / # Example -// / -// / ``` -// / use icu_displaynames::{DisplayNamesOptios, ScriptDisplayNames}; -// / use icu_locid::{locale, subtags_script as script}; -// / -// / let locale = locale!("en-001"); -// / let options: DisplayNamesOptions = Default::default(); -// / let display_name = ScriptDisplayNames::try_new_unstable( -// / &icu_testdata::unstable(), -// / &locale.into(), -// / options, -// / ) -// / .expect("Data should load successfully"); -// / -// / assert_eq!(display_name.of(script!("Hant")), Some("United Arab Emirates")); -// / ``` +/// Lookup of the locale-specific display names by script code. +/// +/// # Example +/// +/// ``` +/// use icu_displaynames::{DisplayNamesOptions, ScriptDisplayNames}; +/// use icu_locid::{locale, subtags_script as script}; +/// +/// let locale = locale!("en-001"); +/// let options: DisplayNamesOptions = Default::default(); +/// let display_name = ScriptDisplayNames::try_new_unstable( +/// &icu_testdata::unstable(), +/// &locale.into(), +/// options, +/// ) +/// .expect("Data should load successfully"); +/// +/// assert_eq!(display_name.of(script!("Maya")), Some("Mayan hieroglyphs")); +/// ``` #[derive(Default)] pub struct ScriptDisplayNames { options: DisplayNamesOptions, diff --git a/experimental/displaynames/src/lib.rs b/experimental/displaynames/src/lib.rs index f51534c040e..a2de2989e13 100644 --- a/experimental/displaynames/src/lib.rs +++ b/experimental/displaynames/src/lib.rs @@ -42,6 +42,7 @@ pub mod provider; pub use displaynames::LanguageDisplayNames; pub use displaynames::LocaleDisplayNamesFormatter; pub use displaynames::RegionDisplayNames; +pub use displaynames::ScriptDisplayNames; pub use options::DisplayNamesOptions; pub use options::Fallback; pub use options::LanguageDisplay; diff --git a/provider/datagen/src/transform/cldr/displaynames/script.rs b/provider/datagen/src/transform/cldr/displaynames/script.rs index 62d6118af20..09a2cc74356 100644 --- a/provider/datagen/src/transform/cldr/displaynames/script.rs +++ b/provider/datagen/src/transform/cldr/displaynames/script.rs @@ -56,6 +56,7 @@ impl IterableDataProvider for crate::DatagenProvider } /// Substring used to denote alternative display names data variants for a given script. For example: "BA-alt-short", "TL-alt-variant". +/// TODO(#3316): Distinguish stand-alone ("Traditional Han") from default ("Traditional") const ALT_SUBSTRING: &str = "-alt-"; /// Substring used to denote short display names data variants for a given script. For example: "az-alt-short". const ALT_SHORT_SUBSTRING: &str = "-alt-short";