refactor (components): Wizard instead full form, add loader #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now list can have only 10 items on start, and loader can load more items if need
iTechJ
approved these changes
Oct 12, 2018
| ...this.state, contact: this.props.contact, | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
Обычно за этим eslint следит, постарайся методы жизненного цикла на верху компонента держать, кроме render - он внизу
| contact: { | ||
| }, | ||
| contact: {}, | ||
| step: 'personal', |
There was a problem hiding this comment.
Это лучше сделать константой над компонентом, а не строкой в коде.
| {/*<label htmlFor="comment" className="contact-create-form__label">Comment:</label>*/} | ||
| {/*<input name="comment" id="comment" type="text" placeholder="Comment" className="contact-create-form__input" value={this.state.contact.phone} onChange={this.handleInputChange}/>*/} | ||
| {/*</div>*/} | ||
| {/*</div>*/} |
There was a problem hiding this comment.
ну и коменты лучше не комитить
| import { connect } from 'react-redux' | ||
| import AdditionalStep | ||
| from '../AdditionalStep' | ||
| import { saveContactData } from '../../../actions/actions' |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now list can have only 10 items on start, and loader can load more items if need