Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isURL() returns false for long urls #2348

Closed
prionkor opened this issue Dec 19, 2023 · 6 comments
Closed

isURL() returns false for long urls #2348

prionkor opened this issue Dec 19, 2023 · 6 comments
Labels

Comments

@prionkor
Copy link

Describe the bug
Consider this url from google business

https://www.google.com/localservices/prolist?g2lbs=ANTchaO7ZRQwN2tLGCBSgW-Opb6NaHr96sWzlu-H4w3m7rbPzfnE5E2oWHCEfWEiYmZqHcpaV5GUr92Ogj3qPnhGRd9MYryeA2PvteIvVod0qsCuYCmzZnaGRU-wIJlycsHYWsb02hv7&hl=es-ES&gl=es&ssta=1&q=fitness Vitoria&oq=fitness Vitoria&src=2&serdesk=1&sa=X&ved=2ahUKEwias4ftxuuCAxV1V6QEHX0wCO8QjGp6BAgmEAE&spp=Cg0vZy8xMWp5ZzhoaGhnOnxXaE1RQUNJUFptbDBibVZ6Y3lCMmFYUnZjbWxocWdGRkVBRXFDeUlIWm1sMGJtVnpjeWdPTWg4UUFTSWIxU250NnNNc3RzY0dPekhaRHVKZ0xFY1FWdVJ4VnNyZGtnQlRNaE1RQWlJUFptbDBibVZ6Y3lCMmFYUnZjbWxo&slp=MgBAAVIECAIgAGAAaAGaAQYKAhcZEAA=&scp=ChZnY2lkOmd5bW5hc3RpY3NfY2VudGVyEiUiDXpvbmEgZGVsIG1hcGEqFA1MG4QZFQY8YP4d_IqPGSX-F3P-GgdmaXRuZXNzKghHaW1uYXNpbw==](https://www.google.com/localservices/prolist?g2lbs=ANTchaO7ZRQwN2tLGCBSgW-Opb6NaHr96sWzlu-H4w3m7rbPzfnE5E2oWHCEfWEiYmZqHcpaV5GUr92Ogj3qPnhGRd9MYryeA2PvteIvVod0qsCuYCmzZnaGRU-wIJlycsHYWsb02hv7&hl=es-ES&gl=es&ssta=1&q=fitness%20Vitoria&oq=fitness%20Vitoria&src=2&serdesk=1&sa=X&ved=2ahUKEwias4ftxuuCAxV1V6QEHX0wCO8QjGp6BAgmEAE&spp=Cg0vZy8xMWp5ZzhoaGhnOnxXaE1RQUNJUFptbDBibVZ6Y3lCMmFYUnZjbWxocWdGRkVBRXFDeUlIWm1sMGJtVnpjeWdPTWg4UUFTSWIxU250NnNNc3RzY0dPekhaRHVKZ0xFY1FWdVJ4VnNyZGtnQlRNaE1RQWlJUFptbDBibVZ6Y3lCMmFYUnZjbWxo&slp=MgBAAVIECAIgAGAAaAGaAQYKAhcZEAA%3D&scp=ChZnY2lkOmd5bW5hc3RpY3NfY2VudGVyEiUiDXpvbmEgZGVsIG1hcGEqFA1MG4QZFQY8YP4d_IqPGSX-F3P-GgdmaXRuZXNzKghHaW1uYXNpbw%3D%3D

When we pass this to isURL() it returns false.

Examples

const url = `https://www.google.com/localservices/prolist?g2lbs=ANTchaO7ZRQwN2tLGCBSgW-Opb6NaHr96sWzlu-H4w3m7rbPzfnE5E2oWHCEfWEiYmZqHcpaV5GUr92Ogj3qPnhGRd9MYryeA2PvteIvVod0qsCuYCmzZnaGRU-wIJlycsHYWsb02hv7&hl=es-ES&gl=es&ssta=1&q=fitness Vitoria&oq=fitness Vitoria&src=2&serdesk=1&sa=X&ved=2ahUKEwias4ftxuuCAxV1V6QEHX0wCO8QjGp6BAgmEAE&spp=Cg0vZy8xMWp5ZzhoaGhnOnxXaE1RQUNJUFptbDBibVZ6Y3lCMmFYUnZjbWxocWdGRkVBRXFDeUlIWm1sMGJtVnpjeWdPTWg4UUFTSWIxU250NnNNc3RzY0dPekhaRHVKZ0xFY1FWdVJ4VnNyZGtnQlRNaE1RQWlJUFptbDBibVZ6Y3lCMmFYUnZjbWxo&slp=MgBAAVIECAIgAGAAaAGaAQYKAhcZEAA=&scp=ChZnY2lkOmd5bW5hc3RpY3NfY2VudGVyEiUiDXpvbmEgZGVsIG1hcGEqFA1MG4QZFQY8YP4d_IqPGSX-F3P-GgdmaXRuZXNzKghHaW1uYXNpbw==](https://www.google.com/localservices/prolist?g2lbs=ANTchaO7ZRQwN2tLGCBSgW-Opb6NaHr96sWzlu-H4w3m7rbPzfnE5E2oWHCEfWEiYmZqHcpaV5GUr92Ogj3qPnhGRd9MYryeA2PvteIvVod0qsCuYCmzZnaGRU-wIJlycsHYWsb02hv7&hl=es-ES&gl=es&ssta=1&q=fitness%20Vitoria&oq=fitness%20Vitoria&src=2&serdesk=1&sa=X&ved=2ahUKEwias4ftxuuCAxV1V6QEHX0wCO8QjGp6BAgmEAE&spp=Cg0vZy8xMWp5ZzhoaGhnOnxXaE1RQUNJUFptbDBibVZ6Y3lCMmFYUnZjbWxocWdGRkVBRXFDeUlIWm1sMGJtVnpjeWdPTWg4UUFTSWIxU250NnNNc3RzY0dPekhaRHVKZ0xFY1FWdVJ4VnNyZGtnQlRNaE1RQWlJUFptbDBibVZ6Y3lCMmFYUnZjbWxo&slp=MgBAAVIECAIgAGAAaAGaAQYKAhcZEAA%3D&scp=ChZnY2lkOmd5bW5hc3RpY3NfY2VudGVyEiUiDXpvbmEgZGVsIG1hcGEqFA1MG4QZFQY8YP4d_IqPGSX-F3P-GgdmaXRuZXNzKghHaW1uYXNpbw%3D%3D`;


console.log(validator.isURL(url)); // false

JS Fiddle: https://jsfiddle.net/sisir/w49mhvne/

Additional context
Validator.js version: 13.11.0
Node.js version: N/A
OS platform: [windows, linux, macOS, etc] N/A

@WikiRik
Copy link
Member

WikiRik commented Dec 19, 2023

This is a duplicate of #1875

The spaces in the URL should have been encoded to '%20' but not all have, causing the validator to (in my opinion correctly) return false.

Btw; When I got a notification about this issue in my mail, Gmail on Android also did not recognize it as a valid URL.

@WikiRik WikiRik closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2023
@prionkor
Copy link
Author

thanks, I agree with you..

@prionkor
Copy link
Author

prionkor commented Jan 28, 2024

@WikiRik This is another example form google, that validator.js showing as invalid. It doesn't have space.

JSFiddle: https://jsfiddle.net/sisir/uj6ywev9/
URL:

https://www.google.com/localservices/prolist?g2lbs=AIQllVwJHUEZa2n1HMgVvZN2pJQMN8LhNEPrYKD_Bn_PajSeRO8C-Mgag8GBQEUNR9_WIGmbmG7vsZv5IvHmPxJCn4EyxEdqaOr8JnMW1g379VwR51TgEeqLocMQWR8h8CbkyUWMbzvgkAi5lAa8-Z5ipjm37kn9R7xEigKjyZcZOm_NyIgNPmM%3D&hl=en-US&gl=us&cs=1&ssta=1&q=damp%20solving%20water%20and%20mold%20removal%20orlando%20fl&oq=damp%20solving%20water%20and%20mold%20removal%20fl&slp=MgA6HENoTUk0TWVKcWZYOWd3TVY2NEZRQmgwUWRRQU9SAggCYAB61gNDaVprWVcxd0lITnZiSFpwYm1jZ2QyRjBaWElnWVc1a0lHMXZiR1FnY21WdGIzWmhiQ0JtYkVpMDJ2LUhyYkdBZ0FoYVJoQUFFQUVRQWhBREVBUVFCUmdBR0FFWUFoZ0VHQVVZQmlJbVpHRnRjQ0J6YjJ4MmFXNW5JSGRoZEdWeUlHRnVaQ0J0YjJ4a0lISmxiVzkyWVd3Z1ptd3FCQWdERUFXU0FTQjNZWFJsY2w5a1lXMWhaMlZmY21WemRHOXlZWFJwYjI1ZmMyVnlkbWxqWlpvQkkwTm9Xa1JUVldoT1RVYzVibE13VmtwUk1FWnVVMVZTVjJGcVZqRmlSMVp1UlVGRnFnR1dBUW9JTDIwdk1EZ3pPR1lLQ0M5dEx6QXllSEo1Q2dndmJTOHdaR3Q0YlJBQktpY2lJMlJoYlhBZ2MyOXNkbWx1WnlCM1lYUmxjaUJoYm1RZ2JXOXNaQ0J5WlcxdmRtRnNLQUF5SHhBQklodHlEaExzYW5NNFZMVVRIZzEzZFlKOTFaYVpJZmRBdUlaZTBKRXlLaEFDSWlaa1lXMXdJSE52YkhacGJtY2dkMkYwWlhJZ1lXNWtJRzF2YkdRZ2NtVnRiM1poYkNCbWJPQUJBQZIBXQoNL2cvMTFrYzhoX3c5bgoNL2cvMTFzazdrMGxtYwoNL2cvMTFxNThkYjAybAoNL2cvMTF0eG5uZHB2ZAoNL2cvMTFrYzF6cWY1bhIEIgIIAhIEEgIIARIECgIIAQ%3D%3D&src=2&spp=Cg0vZy8xMWtjOGhfdzluOpADV2tZUUFCQUJFQUlRQXhBRUVBVVlBQmdCR0FJWUJCZ0ZHQVlpSm1SaGJYQWdjMjlzZG1sdVp5QjNZWFJsY2lCaGJtUWdiVzlzWkNCeVpXMXZkbUZzSUdac0tnUUlBeEFGa2dFZ2QyRjBaWEpmWkdGdFlXZGxYM0psYzNSdmNtRjBhVzl1WDNObGNuWnBZMldhQVNORGFGcEVVMVZvVGsxSE9XNVRNRlpLVVRCR2JsTlZVbGRoYWxZeFlrZFdia1ZCUmFvQmxnRUtDQzl0THpBNE16aG1DZ2d2YlM4d01uaHllUW9JTDIwdk1HUnJlRzBRQVNvbklpTmtZVzF3SUhOdmJIWnBibWNnZDJGMFpYSWdZVzVrSUcxdmJHUWdjbVZ0YjNaaGJDZ0FNaDhRQVNJYmNnNFM3R3B6T0ZTMUV4NE5kM1dDZmRXV21TSDNRTGlHWHRDUk1pb1FBaUltWkdGdGNDQnpiMngyYVc1bklIZGhkR1Z5SUdGdVpDQnRiMnhrSUhKbGJXOTJZV3dnWm13PQ%3D%3D&lrlstt=1706370492551&ved=2ahUKEwjth4Op9f2DAxVNU0EAHbUQA5kQvS56BAgjEAE&scp=CiVnY2lkOndhdGVyX2RhbWFnZV9yZXN0b3JhdGlvbl9zZXJ2aWNlEjUSEgm_KlaRZXbBiBHQTsdb0xMu9yIHRmxvcmlkYSoUDciUig4V4PnDyx1QX3oSJazjVNAwABojZGFtcCBzb2x2aW5nIHdhdGVyIGFuZCBtb2xkIHJlbW92YWwiJmRhbXAgc29sdmluZyB3YXRlciBhbmQgbW9sZCByZW1vdmFsIGZsKiBXYXRlciBkYW1hZ2UgcmVzdG9yYXRpb24gc2VydmljZToCMAI%3D

Is there a way to find out why it is failing?

@WikiRik
Copy link
Member

WikiRik commented Jan 28, 2024

You can just debug it, but I expect the URL is too long and therefore marked as invalid

@prionkor
Copy link
Author

okay, I did a test with php, and it passed as valid:

if (filter_var($url, FILTER_VALIDATE_URL)) {
  echo("$url is a valid URL");
} else {
  echo("$url is not a valid URL");
}

@prionkor
Copy link
Author

prionkor commented Jan 28, 2024

Thank you for the hint, I see there is a limit for url length. I have set validate_length to false. now it is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants