New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra characters to escape #516

Closed

bilbolovespotter opened this issue Mar 5, 2016 · 1 comment

Labels

🙋‍♂️feature-request

bilbolovespotter commented Mar 5, 2016

Hi guys,

I think we should escape a few more dangerous characters for SQL and Javascript.

These two:

'
\

' is dangerous in sql and javascript and \ is too.

node_modules/validator/lib/filter.js
@@ -64,6 +64,7 @@ Filter.prototype.trim = function(chars) {
 Filter.prototype.escape = function() {
     this.modify(this.str.replace(/&/g, '&amp;')
                         .replace(/"/g, '&quot;')
+                        .replace(/'/g, '&#39;')
+                        .replace(/\\/g, '&#5C;')

The text was updated successfully, but these errors were encountered:

Collaborator

chriso commented Mar 5, 2016

Happy to accept a PR 😄

chriso added the 🙋‍♂️feature-request label

chriso closed this as completed in

534a35e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment