Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream gotestsum changes used by acc test suite #218

Closed
ddelnano opened this issue Dec 7, 2022 · 2 comments
Closed

Upstream gotestsum changes used by acc test suite #218

ddelnano opened this issue Dec 7, 2022 · 2 comments

Comments

@ddelnano
Copy link
Collaborator

ddelnano commented Dec 7, 2022

In #188, I decided to modify gotestsum in order to allow it to rerun tests that have panic'ed (ddelnano/gotestsum@8c70ff0). This is common in the acceptance test suite because many of the VM tests take a long time to run and result in flaky builds due to the timeouts.

We should upstream these changes so that it isn't required to use my fork of the gotestsum repository long term. From my work in this space, gotestsum has a history of dealing with go's timeout panic behavior (gotestyourself/gotestsum#192, golang/go#45508, golang/go#38382). The maintainer of the project has disabled this behavior, but I'm hopeful it would be accepted behind a runtime toggle.

@ddelnano
Copy link
Collaborator Author

ddelnano commented Dec 8, 2022

I've created an issue to inquire if this contribution would be accepted (gotestyourself/gotestsum#290)

@ddelnano
Copy link
Collaborator Author

This is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant