From 7bb42b4ca054144b1b1c049db73e36e9496fe79f Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Tue, 16 Jan 2024 17:48:27 -0500 Subject: [PATCH] [wasm] WBT: disable failing tests Issue: https://github.com/dotnet/runtime/issues/97054 --- src/mono/wasm/Wasm.Build.Tests/Blazor/BuildPublishTests.cs | 2 ++ src/mono/wasm/Wasm.Build.Tests/Blazor/IcuShardingTests.cs | 2 ++ src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs | 5 ++++- src/mono/wasm/Wasm.Build.Tests/Blazor/MiscTests3.cs | 1 + .../Wasm.Build.Tests/Blazor/SimpleMultiThreadedTests.cs | 1 + src/mono/wasm/Wasm.Build.Tests/Blazor/SimpleRunTests.cs | 2 ++ .../wasm/Wasm.Build.Tests/Blazor/WorkloadRequiredTests.cs | 1 + .../wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs | 7 ++++--- .../Wasm.Build.Tests/TestAppScenarios/AppSettingsTests.cs | 1 + .../Wasm.Build.Tests/TestAppScenarios/LazyLoadingTests.cs | 2 ++ .../TestAppScenarios/LibraryInitializerTests.cs | 2 ++ .../TestAppScenarios/SatelliteLoadingTests.cs | 1 + 12 files changed, 23 insertions(+), 4 deletions(-) diff --git a/src/mono/wasm/Wasm.Build.Tests/Blazor/BuildPublishTests.cs b/src/mono/wasm/Wasm.Build.Tests/Blazor/BuildPublishTests.cs index e7be07f71c89e..0157118771a66 100644 --- a/src/mono/wasm/Wasm.Build.Tests/Blazor/BuildPublishTests.cs +++ b/src/mono/wasm/Wasm.Build.Tests/Blazor/BuildPublishTests.cs @@ -26,6 +26,7 @@ public BuildPublishTests(ITestOutputHelper output, SharedBuildPerTestClassFixtur [Theory, TestCategory("no-workload")] [InlineData("Debug")] [InlineData("Release")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task DefaultTemplate_WithoutWorkload(string config) { string id = $"blz_no_workload_{config}_{GetRandomId()}_{s_unicodeChar}"; @@ -177,6 +178,7 @@ void AssertResourcesDlls(string basePath) [Theory] [InlineData("", true)] // Default case [InlineData("false", false)] // the other case + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task Test_WasmStripILAfterAOT(string stripILAfterAOT, bool expectILStripping) { string config = "Release"; diff --git a/src/mono/wasm/Wasm.Build.Tests/Blazor/IcuShardingTests.cs b/src/mono/wasm/Wasm.Build.Tests/Blazor/IcuShardingTests.cs index aa19657015185..7bfa39e3fe52b 100644 --- a/src/mono/wasm/Wasm.Build.Tests/Blazor/IcuShardingTests.cs +++ b/src/mono/wasm/Wasm.Build.Tests/Blazor/IcuShardingTests.cs @@ -24,6 +24,7 @@ public IcuShardingTests(ITestOutputHelper output, SharedBuildPerTestClassFixture [InlineData("Release", "icudt.dat")] [InlineData("Debug", "icudt_CJK.dat")] [InlineData("Release", "icudt_CJK.dat")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task CustomIcuFileFromRuntimePack(string config, string fileName) { string id = $"blz_customFromRuntimePack_{config}_{GetRandomId()}"; @@ -90,6 +91,7 @@ public void NonExistingCustomFileAssertError(string config, string fileName, boo [Theory] [InlineData("Debug")] [InlineData("Release")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task CustomFileNotFromRuntimePackAbsolutePath(string config) { string id = $"blz_invalidCustomIcu_{config}_{GetRandomId()}"; diff --git a/src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs b/src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs index 728eb96386b2e..7169e14b36ae4 100644 --- a/src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs +++ b/src/mono/wasm/Wasm.Build.Tests/Blazor/IcuTests.cs @@ -26,6 +26,7 @@ public IcuTests(ITestOutputHelper output, SharedBuildPerTestClassFixture buildCo [InlineData("Release", false)] [InlineData("Release", true)] [InlineData("Release", null)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task HybridWithInvariant(string config, bool? invariant) { string id = $"blz_hybrid_{config}_{GetRandomId()}"; @@ -64,6 +65,7 @@ public async Task HybridWithInvariant(string config, bool? invariant) [InlineData("Release", false)] [InlineData("Release", true)] [InlineData("Release", null)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task HybridWithFullIcuFromRuntimePack(string config, bool? fullIcu) { string id = $"blz_hybrid_{config}_{GetRandomId()}"; @@ -101,6 +103,7 @@ public async Task HybridWithFullIcuFromRuntimePack(string config, bool? fullIcu) [InlineData("Release", false)] [InlineData("Release", true)] [InlineData("Release", null)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task FullIcuFromRuntimePackWithInvariant(string config, bool? invariant) { string id = $"blz_hybrid_{config}_{GetRandomId()}"; @@ -131,4 +134,4 @@ public async Task FullIcuFromRuntimePackWithInvariant(string config, bool? invar await BlazorRunForBuildWithDotnetRun(new BlazorRunOptions() { Config = config }); } -} \ No newline at end of file +} diff --git a/src/mono/wasm/Wasm.Build.Tests/Blazor/MiscTests3.cs b/src/mono/wasm/Wasm.Build.Tests/Blazor/MiscTests3.cs index 10717b334174b..3bd5ddd8bd02a 100644 --- a/src/mono/wasm/Wasm.Build.Tests/Blazor/MiscTests3.cs +++ b/src/mono/wasm/Wasm.Build.Tests/Blazor/MiscTests3.cs @@ -30,6 +30,7 @@ public MiscTests3(ITestOutputHelper output, SharedBuildPerTestClassFixture build [InlineData("Release", /*build*/false, /*publish*/true)] [InlineData("Release", /*build*/true, /*publish*/true)] [ActiveIssue("https://github.com/dotnet/runtime/issues/87877", TestPlatforms.Windows)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task WithDllImportInMainAssembly(string config, bool build, bool publish) { // Based on https://github.com/dotnet/runtime/issues/59255 diff --git a/src/mono/wasm/Wasm.Build.Tests/Blazor/SimpleMultiThreadedTests.cs b/src/mono/wasm/Wasm.Build.Tests/Blazor/SimpleMultiThreadedTests.cs index c28f18a3c5746..d5b96055ddc6d 100644 --- a/src/mono/wasm/Wasm.Build.Tests/Blazor/SimpleMultiThreadedTests.cs +++ b/src/mono/wasm/Wasm.Build.Tests/Blazor/SimpleMultiThreadedTests.cs @@ -42,6 +42,7 @@ public SimpleMultiThreadedTests(ITestOutputHelper output, SharedBuildPerTestClas // [InlineData("Debug", true)] [InlineData("Release", false)] // [InlineData("Release", true)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task BlazorPublishRunTest(string config, bool aot) { string id = $"blazor_mt_{config}_{GetRandomId()}"; diff --git a/src/mono/wasm/Wasm.Build.Tests/Blazor/SimpleRunTests.cs b/src/mono/wasm/Wasm.Build.Tests/Blazor/SimpleRunTests.cs index fdce8ea756f84..74d1fdf3f35e2 100644 --- a/src/mono/wasm/Wasm.Build.Tests/Blazor/SimpleRunTests.cs +++ b/src/mono/wasm/Wasm.Build.Tests/Blazor/SimpleRunTests.cs @@ -39,6 +39,7 @@ public async Task BlazorBuildRunTest(string config) [InlineData("Debug", /*appendRID*/ true, /*useArtifacts*/ true)] [InlineData("Debug", /*appendRID*/ false, /*useArtifacts*/ true)] [InlineData("Debug", /*appendRID*/ false, /*useArtifacts*/ false)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task BlazorBuildAndRunForDifferentOutputPaths(string config, bool appendRID, bool useArtifacts) { string id = $"{config}_{GetRandomId()}"; @@ -81,6 +82,7 @@ public async Task BlazorBuildAndRunForDifferentOutputPaths(string config, bool a [InlineData("Debug", true)] [InlineData("Release", false)] [InlineData("Release", true)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task BlazorPublishRunTest(string config, bool aot) { string id = $"blazor_{config}_{GetRandomId()}"; diff --git a/src/mono/wasm/Wasm.Build.Tests/Blazor/WorkloadRequiredTests.cs b/src/mono/wasm/Wasm.Build.Tests/Blazor/WorkloadRequiredTests.cs index b811d2b7dc916..643b247484794 100644 --- a/src/mono/wasm/Wasm.Build.Tests/Blazor/WorkloadRequiredTests.cs +++ b/src/mono/wasm/Wasm.Build.Tests/Blazor/WorkloadRequiredTests.cs @@ -76,6 +76,7 @@ public static TheoryData InvariantGlobalizationTestData(bool [Theory, TestCategory("no-workload")] [MemberData(nameof(InvariantGlobalizationTestData), parameters: /*publish*/ false)] [MemberData(nameof(InvariantGlobalizationTestData), parameters: /*publish*/ true)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task WorkloadNotRequiredForInvariantGlobalization(string config, bool invariant, bool publish) { string id = $"props_req_workload_{(publish ? "publish" : "build")}_{GetRandomId()}"; diff --git a/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs b/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs index 4a93f148d0cb9..98d0331bb620b 100644 --- a/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs +++ b/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs @@ -254,9 +254,9 @@ void AddTestData(bool forConsole, bool runOutsideProjectDirectory) [Theory] [MemberData(nameof(TestDataForAppBundleDir))] public async Task RunWithDifferentAppBundleLocations(bool forConsole, bool runOutsideProjectDirectory, string extraProperties) - => await (forConsole - ? ConsoleRunWithAndThenWithoutBuildAsync("Release", extraProperties, runOutsideProjectDirectory) - : BrowserRunTwiceWithAndThenWithoutBuildAsync("Release", extraProperties, runOutsideProjectDirectory)); + => await (forConsole, ConsoleRunWithAndThenWithoutBuildAsync("Release", extraProperties, runOutsideProjectDirectory); + // [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] + //: BrowserRunTwiceWithAndThenWithoutBuildAsync("Release", extraProperties, runOutsideProjectDirectory)); private async Task BrowserRunTwiceWithAndThenWithoutBuildAsync(string config, string extraProperties = "", bool runOutsideProjectDirectory = false) { @@ -416,6 +416,7 @@ public void ConsolePublishAndRun(string config, bool aot, bool relinking) // [ActiveIssue("https://github.com/dotnet/runtime/issues/90979")] // [InlineData("", BuildTestBase.DefaultTargetFramework, "./")] // [InlineData("-f net8.0", "net8.0", "./")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task BrowserBuildAndRun(string extraNewArgs, string targetFramework, string runtimeAssetsRelativePath) { string config = "Debug"; diff --git a/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/AppSettingsTests.cs b/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/AppSettingsTests.cs index 96f2c4ebd6a1b..aa39b1a376bc8 100644 --- a/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/AppSettingsTests.cs +++ b/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/AppSettingsTests.cs @@ -23,6 +23,7 @@ public AppSettingsTests(ITestOutputHelper output, SharedBuildPerTestClassFixture [Theory] [InlineData("Development")] [InlineData("Production")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task LoadAppSettingsBasedOnApplicationEnvironment(string applicationEnvironment) { CopyTestAsset("WasmBasicTestApp", "AppSettingsTests"); diff --git a/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/LazyLoadingTests.cs b/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/LazyLoadingTests.cs index d2219e9f9e50d..ec73cf68361ec 100644 --- a/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/LazyLoadingTests.cs +++ b/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/LazyLoadingTests.cs @@ -21,6 +21,7 @@ public LazyLoadingTests(ITestOutputHelper output, SharedBuildPerTestClassFixture } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task LoadLazyAssemblyBeforeItIsNeeded() { CopyTestAsset("WasmBasicTestApp", "LazyLoadingTests"); @@ -31,6 +32,7 @@ public async Task LoadLazyAssemblyBeforeItIsNeeded() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task FailOnMissingLazyAssembly() { CopyTestAsset("WasmBasicTestApp", "LazyLoadingTests"); diff --git a/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/LibraryInitializerTests.cs b/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/LibraryInitializerTests.cs index 6f68a96ad1d61..2227c05f19498 100644 --- a/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/LibraryInitializerTests.cs +++ b/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/LibraryInitializerTests.cs @@ -24,6 +24,7 @@ public LibraryInitializerTests(ITestOutputHelper output, SharedBuildPerTestClass } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task LoadLibraryInitializer() { CopyTestAsset("WasmBasicTestApp", "LibraryInitializerTests_LoadLibraryInitializer"); @@ -37,6 +38,7 @@ public async Task LoadLibraryInitializer() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task AbortStartupOnError() { CopyTestAsset("WasmBasicTestApp", "LibraryInitializerTests_AbortStartupOnError"); diff --git a/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/SatelliteLoadingTests.cs b/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/SatelliteLoadingTests.cs index 31dcb65582869..b82fae815234e 100644 --- a/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/SatelliteLoadingTests.cs +++ b/src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/SatelliteLoadingTests.cs @@ -24,6 +24,7 @@ public SatelliteLoadingTests(ITestOutputHelper output, SharedBuildPerTestClassFi } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/97054")] public async Task LoadSatelliteAssembly() { CopyTestAsset("WasmBasicTestApp", "SatelliteLoadingTests");